-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing select mode #31236
Comments
I am not totally sure about this one, I've found it mostly confusing in the site editor and it starts to diminish the clarity of the currently selected item. I think it can make sense for template part containers, but given the work to have overlays and isolated views it might not be necessary anymore. |
Yes, I think the parent outline style should be tied to the click-through UI. That is to say: the parent outline should only be applied in situations where the click-through itself is utilised. And of course only if the click-through UI itself makes use of a parent outline style. |
Hey @jameskoster , interesting to see your thoughts – I created very similar issues some months ago with analysis, examples and screenshots – maybe it is of any help for you:
Feel free to ask (GitHub or DM) if I can help you in any way to bring things forward! |
At the moment the Toggling between the two modes would be easier if we could just press |
While a toggle could be a helpful secondary affordance, I wonder if the most intuitive heuristic would be to simply re-engage select mode whenever no block is actively selected. We may also need to be careful about toggling modes on a single key, as it may be that there are more than two modes in the future. Dedicated shortcuts for each mode might be more scalable. |
This could work, and it would allow us to let an additional Escape deselect all blocks something that in many apps is tied to that key already. |
Is this issue still useful for tracking improvements? |
Probably not. Many things have changed since this issue was opened, which brings a few of the items into question. |
In the Site Editor we've made a number of enhancements to the interactions around block selection. In particular indicating block outlines on hover / focus, aligning those styles with the new persistent list view, and indicating the parent container of the selected block on the canvas. We're also experimenting with click-through patterns (#30156 #31109) for containers like Reusable Blocks and Template Parts. So far these enhancements have been made to Edit mode in the Site Editor exclusively.
Some of these interactions already exist in one form or another in Select mode. So it may soon be time to think about aligning Edit mode in the Site editor with Select mode everywhere else. With alignment and consistent mode behaviour across editors we can then consider making Select the default mode in the Site Editor, where nested blocks and complex layouts are more common.
Here's what we can take from the work we've done so far in the Site Editor, and apply to Select mode holistically:
And here are some other enhancement ideas to explore:
And some 🐛 to squash:
Figma file to explore issues that need design here.
The text was updated successfully, but these errors were encountered: