Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search block: The block gets selected after adding a media item on another block #31351

Closed
fluiddot opened this issue Apr 29, 2021 · 2 comments · Fixed by #31393 or wordpress-mobile/gutenberg-mobile#3442
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

Description

After adding the search block into a post, it gets automatically selected after adding or replacing media items on other media blocks like the image block.

Step-by-step reproduction instructions

  1. Add a search block
  2. Add an image block
  3. Select an image to be inserted in the image block
  4. Observe that after the image is added the search block gets selected

Expected behaviour

The image block should be kept selected after adding an image.

Actual behaviour

The search block gets selected instead of the image block.

Screenshots or screen recording (optional)

search-block-focus-issue.mp4

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: iPhone 8 (simulator)
  • Operating system: iOS 14.2
  • WordPress app version: develop
@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Apr 29, 2021
@fluiddot
Copy link
Contributor Author

In some cases, I experienced a crash although I couldn't reproduce the exact steps. What I saw is that the scroll begins to jump from one place to another very quickly and then crashes, my impression was that different blocks were requesting focus and somehow the app enters in an infinite loop.

@AmandaRiu I ping you here as I saw that you recently enabled this block in this PR.

@AmandaRiu AmandaRiu self-assigned this Apr 29, 2021
@AmandaRiu
Copy link
Contributor

Thanks @fluiddot, I'll take a look at this and see if I can figure out what is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
3 participants