[RNMobile] Fix Issue with Search block stealing focus after media updated for image block #31393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue on iOS where search block would steal the focus from the image block after selecting an image.
Now that the isSelected state of the search input field is no longer defaulted to true (because it was stealing focus from other components), we need to make sure that the block is actively selected prior to each test. While making these changes I also consolidated and reorganized the tests for code reusability.
This avoids some test flakiness on Android
AmandaRiu
added
[Block] Search
2 tasks
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
dcalhoun
approved these changes
May 3, 2021
packages/react-native-editor/__device-tests__/gutenberg-editor-search.test.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile Gutenberg PR: wordpress-mobile/gutenberg-mobile#3442
Description
Fixes #31351 where the Search block was stealing the focus away from the Image block after the image was updated (iOS only). The fix itself was really straightforward - at some point I defaulted the
isPlaceholderSelectedstate variable totruebut this is not necessary and was forcing the search input element of the Search block to gain focus and take focus from the image block. Defaulting this tofalsefixed the issue. While this change was tiny, it required fixes to both the Unit Test snapshot and the e2e tests.How has this been tested?
Tested the following scenario on both Android and iOS:
Run unit tests
Run e2e tests
IOS
Android
Screenshots
Before
Screen.Recording.2021-04-30.at.2.34.19.PM.mov
After
Screen.Recording.2021-04-30.at.2.35.02.PM.mov
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).