Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Low Contrast Checker/Notice for Text-Based Blocks #33396

Closed
SiobhyB opened this issue Jul 13, 2021 · 3 comments · Fixed by #34902 or wordpress-mobile/gutenberg-mobile#4357
Closed
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Jul 13, 2021

Description

The option to add colours to text blocks was introduced to the apps in #33250.

A nice feature that accompanies this option on the web is the following notice when colours with a low contrast are being used together:

This colour combination may be hard for people to read. Try using a brighter background colour and/or a darker text colour.

The notice is a useful prompt for site owners that helps to promote accessibility and it could be nice to add to the apps.

Step-by-step reproduction instructions

  • Add a new text block (e.g. the paragraph block) to a new a post in the mobile app and type some text.
  • Tap the block's cog/gear icon to edit its settings.
  • Select a foreground and background colour that have a low contrast to one another (e.g. two really dark colours).
  • Observe how the text is hard to read, but there is no notice like there is on the web.

Screenshots or screen recording

The notice as it appears on the web:

Screenshot 2021-07-13 at 19 55 45

@SiobhyB SiobhyB added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [a11y] Color Contrast labels Jul 13, 2021
@chipsnyder
Copy link
Contributor

This is a great suggestion @SiobhyB!

@SiobhyB SiobhyB changed the title Mobile: Contrast Checker/Notice for Text-Based Blocks Mobile: Low Contrast Checker/Notice for Text-Based Blocks Jul 13, 2021
@jd-alexander
Copy link
Contributor

Good idea! The help prop could be leveraged to include this notice below the colors.

@SiobhyB SiobhyB self-assigned this Sep 13, 2021
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Sep 13, 2021

Noting here that I'll be working on this week, for HACK week, with @iamthomasbishop. :) @iamthomasbishop, an initial question I have is whether you'd like to see this notice on both the colour picker's main sheet and sub sheet.

Main Sheet Sub Sheet

My first thought is that it should appear in both places, but also wonder whether that may make the main sheet seem cluttered for some blocks. Interested to hear your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Enhancement A suggestion for improvement.
Projects
None yet
4 participants