Release 1.70.0 #4491

fluiddot · 2022-01-20T10:28:56Z

Release for Gutenberg Mobile 1.70.0

Related PRs

Gutenberg: Mobile Release v1.70.0 WordPress/gutenberg#38111
WPAndroid: Integrate gutenberg-mobile release 1.70.0 WordPress-Android#15836
WPiOS: Integrate gutenberg-mobile release 1.70.0 WordPress-iOS#17791

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Fix content justification attribute in Buttons block

Hide help button from Unsupported Block Editor

Add contrast checker to text-based blocks

Fix missing Featured Image translations

Fix missing translations of color settings

Fix cut-off setting labels by properly wrapping the text

Highlight text: fix applying formatting for non-selected text

PR: Highlight text - Force format for some edge cases #4471
Issue: N/A

Fix Android handling of Hebrew and Indonesian translations

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

Verify Items from test plan have been completed
Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
Bundle package of the release is updated.

…k-settings Jetpack Tiled Gallery: Settings implementation

…bile.

Jetpack Tiled Gallery Block: Hooking up settings with attributes on block

…karound.

…ursion bug needs further investigation.

…ound

…karound Jetpack Tiled Gallery Block : `save` functionality submodule hash update

Tiled Gallery Block: Aspect Ratio for Square Layout

…laceholder-wording Tiled Gallery Block: Update placeholder text

Initial Port of Jetpack Tiled Gallery Block

…o_develop Merge release 1.69.1 to develop

geriux

LGTM! 🚀

fluiddot · 2022-01-25T11:47:53Z

fluiddot · 2022-01-25T11:48:46Z

🟢 iOS - Unsupported Block Editing - Test Cases

Build: 19.1 (19.1.0.0) from TestFlight
Device: iPhone 11 (iOS 15.1)

Unsupported Block Tests

TC001 User can edit unsupported blocks on Simple WP.com sites
TC002 User can discard edits to an unsupported block on Simple WP.com sites
TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

fluiddot · 2022-01-25T11:51:55Z

🟢 iOS - Test new changes included in `1.70.0` release

Build: 19.1 (19.1.0.0) from TestFlight
Device: iPhone 11 (iOS 15.1)

Buttons block: Fix content justification attribute #4451
Hide help button from UBE #4352
Add Contrast Checker to Text-Based Blocks #4357
Fix missing Featured Image translations #4464
⚠️ I spotted that the strings referenced in the PR are not translated, although this is most likely caused by the fact that localizations in WordPress-iOS haven't been updated yet (comment). We should do another check-in next beta versions once they are updated.
[RNMobile] Retrieve translation of color settings strings #4479
~~Wrap long cell labels on Android #4475~~ (Fix only applies on Android)
Highlight text - Force format for some edge cases #4471
⚠️ I spotted the following issue Highlight text: Format button doesn't match current color when moving the caret WordPress/gutenberg#38246 but it's not a regression as it can also be reproduced in `18.9.
~~Send non-deprecated language tags from Android in initialProps #4397~~ (Fix only applies on Android)

fluiddot · 2022-01-25T11:54:51Z

🟢 iOS - Sanity tests - Test Suite 1

Build: 19.1 (19.1.0.0) from TestFlight
Device: iPhone 11 (iOS 15.1)

Gallery - 1 (tested via `1.70.1` installable build)

Gallery block - Close/Re-open post with an ongoing image upload - TC001
Gallery block - Close post with an ongoing image upload - TC002

NOTE: ~~⚠️ I stopped testing the Gallery block due to this crash: WordPress/gutenberg#38217~~ Fixed in version 1.70.1 (#4518).

Gallery - 2 (tested via `1.70.1` installable build)

Gallery block - Insert image from device (failing) - TC006
Gallery block - Insert image from device (cancel) - TC009

Gallery - 3 (tested via `1.70.1` installable build)

Gallery block - Add Gallery Caption - TC003
Gallery block - Add Gallery Image Caption - TC04
Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

Columns - Columns percentage mechanism - column's preview - TC019
Columns - Columns percentage mechanism - column's slider input - TC020
Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
Columns - Multiple slider in columns parent - TC023
Columns - Adding Column with AppenderButton - TC003
Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

Columns - Max limit of Column number - TC005
Columns - Min limit of Column number - TC006
Columns - Removing Column with remove button - TC007
Columns - Removing the only one left Column with remove button - TC008
Columns - Changing alignment on Columns - TC009
Columns - Changing alignment on individual Column - TC010
Columns - Alignment attribute is properly passed when adding Column - TC011
Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

Columns - Check if Column placeholders is visible for the unselected state - TC002
Columns - Appearance in vertical device position (vertical layout) - TC013
Columns - Appearance in horizontal device position (horizontal layout) - TC014
Columns - Mover direction - TC015
Columns - Check if Column placeholder is render in nested structure - TC016
Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

Media Text block - Insert image from device (failing) - TC001
Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

Media Text block - Insert video from device (TC002) - steps
Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

Simultaneous uploads - TC001

Cover - 1

Cover - Add image background from WordPress Media library - TC001
Cover - Change Minimum height in pixels - TC002
Cover - Change Background Opacity - TC009
Cover - Image focal point is rendered properly - TC003
Cover - Custom color is rendered properly - TC004

Editor Theme - 1

Default Colors - Check that default colors still load - TC001
Default Gradients - Check that default gradients still load - TC002
Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

The newly created Social Icons block is added with 4 icons - TC001
Active icon gets product color - TC002
Only active icons are visible when not selected - TC003

geriux · 2022-01-25T12:33:37Z

geriux · 2022-01-25T12:43:55Z

🟢 Android - Unsupported Block Tests

Build: 19.1-rc-1
Device: Redmi Note 8T (OS 11)

TC001 User can edit unsupported blocks on Simple WP.com sites
TC002 User can discard edits to an unsupported block on Simple WP.com sites
TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

geriux · 2022-01-25T12:54:13Z

🟢 Android - New changes

Build: 19.1-rc-1
Device: Redmi Note 8T (OS 11)

geriux · 2022-01-25T12:56:03Z

🟢 Android - Test suite 2

Build: 19.1-rc-1
Device: Redmi Note 8T (OS 11)

DarkMode - 1

Gallery block - Dark mode - TC001
⚠️ Skipped due to this crash.
Shortcode block - Dark mode - TC002
Media Text block - Dark mode - TC003

Group - 1

Group - AppenderButton is rendered - TC001
Group - Deep nesting is possible (iOS only) - TC002
Group - Check if Group placeholder is visible for the unselected state - TC003
Group - Check if Group placeholder is render in nested structure - TC004
Group - Nested block have proper border styling - TC005
Group - Nested block have proper margins values - TC006
Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

Spacer block - Spacer is rendered without crash - TC001
Spacer block - Settings: Control spacer height using the slider - TC002
Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
Buttons block - Buttons inline appender - TC002
Buttons block - Add another Button inside Buttons using inserter - TC003
Buttons block - Button's wrapper grows properly - TC023

Buttons-2

Buttons block - Removing Button along with Buttons block - TC004
Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

Buttons block - Wrapping Buttons - TC006
Buttons block - Buttons alignment options - TC007

Button-6

Buttons block - Settings: Open in new tab - TC011
Buttons block - Settings: Link rel - TC012
Buttons block - Settings: Link URL - TC010
Buttons block - Settings: Remove link - TC014
Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

Colors Segmented Controls - TC001
Scroll color palette to start - TC002
Scroll color palette to the end - TC003

Image - 1

Image block - Insert image from device (failing) - TC001
Image block - Insert image from device (cancel) - TC002
Image block - Add Caption - TC003
Image block - Close/Re-open post with an ongoing image upload - TC004
Image block - Close post with an ongoing image upload - TC005

Story block - 1

Story block - Verify is available in Block Picker - TC001
Story block - Verify is not available in Block Picker- TC002
Story block - Add media to empty Story block - TC003
Story block - Add media to non-empty Story block - TC004
Story block - Close/Re-open post with an ongoing Story upload - TC005

guarani and others added 30 commits September 23, 2021 09:48

Merge pull request #4015 from wordpress-mobile/add/tiled-gallery-bloc…

769e7f5

…k-settings Jetpack Tiled Gallery: Settings implementation

Update Jetpack reference

1effda7

Update reference to Gutenberg

79ba857

Update Gutenberg reference

5231b63

Bringing columns attributes changes for Jetpack Tiled Gallery to gbmo…

e9a2eab

…bile.

Merge pull request #4141 from wordpress-mobile/tiled-gallery-columns

c4c30ad

Jetpack Tiled Gallery Block: Hooking up settings with attributes on block

Updating submodule hash for jetpack -- Jetpack Tiled Gallery save wor…

c189092

…karound.

Skippiing jetpack tiled gallery unit test for now as the infinite rec…

4421546

…ursion bug needs further investigation.

Merge branch 'develop' into add/tiled-gallery-block

f647bb2

Merge branch 'add/tiled-gallery-block' into add/squared-aspect-ratio

a4de645

Updating jetpack hash for merge conflict.

47b351c

Update Jetpack reference

a281afa

Merge branch 'develop' into tiled-gallery-save-workaround

8b7374e

Merge branch 'add/tiled-gallery-block' into tiled-gallery-save-workar…

4cf52c1

…ound

Updating hash

2089328

update gutenberg submodule ref

cc4977b

Merge branch 'develop' into add/tiled-gallery-block

0d2e9ea

Merged in latest from feature branch

175cf65

Update to Gutenberg feature branch

1eba9e8

Merge pull request #4143 from wordpress-mobile/tiled-gallery-save-wor…

123fda4

…karound Jetpack Tiled Gallery Block : `save` functionality submodule hash update

Update latest reference to Jetpack

ce1d870

Merge branch 'add/tiled-gallery-block' into add/squared-aspect-ratio

d935709

Update reference to Jetpack

cb131a1

Merge pull request #4017 from wordpress-mobile/add/squared-aspect-ratio

392c454

Tiled Gallery Block: Aspect Ratio for Square Layout

Update reference to Jetpack

e17bba2

Update reference to Jetpack

c1815d9

Update Jetpack submodule ref

6cc83e5

Update reference to Jetpack

01d3700

Merge pull request #4194 from wordpress-mobile/update/tiled-gallery-p…

e60ce19

…laceholder-wording Tiled Gallery Block: Update placeholder text

Update Jetpack submodule hash

da045bc

guarani and others added 8 commits January 19, 2022 15:57

Updated Tiled Gallery test

2a4997b

Merge pull request #4291 from wordpress-mobile/add/tiled-gallery-block

a3a0ffb

Initial Port of Jetpack Tiled Gallery Block

Merge branch 'develop' into merge_release_1.69.1_to_develop

797d652

Update gutenberg reference

b5a044d

Merge pull request #4489 from wordpress-mobile/merge_release_1.69.1_t…

93f8a1c

…o_develop Merge release 1.69.1 to develop

Release script: Update gb mobile version to 1.70.0

7ff25d3

Release script: Update gutenberg ref

b321a7c

Release script: Update bundle for: 1.70.0

aca8648

fluiddot added the release-process label Jan 20, 2022

This was referenced Jan 20, 2022

Mobile Release v1.70.0 WordPress/gutenberg#38111

Merged

Integrate gutenberg-mobile release 1.70.0 wordpress-mobile/WordPress-iOS#17791

Merged

Integrate gutenberg-mobile release 1.70.0 wordpress-mobile/WordPress-Android#15836

Merged

fluiddot added 2 commits January 20, 2022 12:15

Update Gutenberg ref

c243eb1

Add 1.70.0 section to release notes

c242a26

fluiddot marked this pull request as ready for review January 20, 2022 12:29

fluiddot requested a review from geriux January 20, 2022 12:29

geriux approved these changes Jan 20, 2022

View reviewed changes

Update bundle

936093f

fluiddot added this to the 1.70.0 (19.1) milestone Jan 20, 2022

fluiddot self-assigned this Jan 20, 2022

fluiddot merged commit d4cfb5b into trunk Jan 20, 2022

fluiddot deleted the release/1.70.0 branch January 20, 2022 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.70.0 #4491

Release 1.70.0 #4491

fluiddot commented Jan 20, 2022 •

edited

Loading

geriux left a comment

fluiddot commented Jan 25, 2022 •

edited

Loading

fluiddot commented Jan 25, 2022 •

edited

Loading

fluiddot commented Jan 25, 2022 •

edited

Loading

fluiddot commented Jan 25, 2022 •

edited

Loading

geriux commented Jan 25, 2022 •

edited

Loading

geriux commented Jan 25, 2022 •

edited

Loading

geriux commented Jan 25, 2022 •

edited

Loading

geriux commented Jan 25, 2022 •

edited

Loading

Release 1.70.0 #4491

Release 1.70.0 #4491

Conversation

fluiddot commented Jan 20, 2022 • edited Loading

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Fix content justification attribute in Buttons block

Hide help button from Unsupported Block Editor

Add contrast checker to text-based blocks

Fix missing Featured Image translations

Fix missing translations of color settings

Fix cut-off setting labels by properly wrapping the text

Highlight text: fix applying formatting for non-selected text

Fix Android handling of Hebrew and Indonesian translations

Test plan

Release Submission Checklist

geriux left a comment

Choose a reason for hiding this comment

fluiddot commented Jan 25, 2022 • edited Loading

🟢 iOS - Writing Flow checklist

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

fluiddot commented Jan 25, 2022 • edited Loading

🟢 iOS - Unsupported Block Editing - Test Cases

Unsupported Block Tests

fluiddot commented Jan 25, 2022 • edited Loading

🟢 iOS - Test new changes included in 1.70.0 release

fluiddot commented Jan 25, 2022 • edited Loading

🟢 iOS - Sanity tests - Test Suite 1

Gallery - 1 (tested via 1.70.1 installable build)

Gallery - 2 (tested via 1.70.1 installable build)

Gallery - 3 (tested via 1.70.1 installable build)

Columns - 1

Columns - 2

Columns - 3

MediaText - 1

MediaText - 2

MultipleUpload - 1

Cover - 1

Editor Theme - 1

Social Icons - 1

geriux commented Jan 25, 2022 • edited Loading

🟢 Android - Writing Flow checklist

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

geriux commented Jan 25, 2022 • edited Loading

🟢 Android - Unsupported Block Tests

geriux commented Jan 25, 2022 • edited Loading

🟢 Android - New changes

geriux commented Jan 25, 2022 • edited Loading

🟢 Android - Test suite 2

DarkMode - 1

Group - 1

Spacer - 1

Buttons-1

Buttons-2

Buttons-3

Button-6

Color Settings - 1

Image - 1

Story block - 1

fluiddot commented Jan 20, 2022 •

edited

Loading

fluiddot commented Jan 25, 2022 •

edited

Loading

fluiddot commented Jan 25, 2022 •

edited

Loading

fluiddot commented Jan 25, 2022 •

edited

Loading

🟢 iOS - Test new changes included in `1.70.0` release

fluiddot commented Jan 25, 2022 •

edited

Loading

Gallery - 1 (tested via `1.70.1` installable build)

Gallery - 2 (tested via `1.70.1` installable build)

Gallery - 3 (tested via `1.70.1` installable build)

geriux commented Jan 25, 2022 •

edited

Loading

geriux commented Jan 25, 2022 •

edited

Loading

geriux commented Jan 25, 2022 •

edited

Loading

geriux commented Jan 25, 2022 •

edited

Loading