Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded Content Block #3497

Closed
2 tasks
darrencoutts118 opened this issue Nov 15, 2017 · 3 comments
Closed
2 tasks

Embedded Content Block #3497

darrencoutts118 opened this issue Nov 15, 2017 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@darrencoutts118
Copy link

Issue Overview

Version 1.7 - This does not look quite right to me? The top links needs some styling or removed.

image

Steps to Reproduce (for bugs)

  1. Install Version 1.7
  2. Edit the demo page
  3. See the last block

Expected Behavior

Visual could look better than it currently does

Current Behavior

Possible Solution

Screenshots / Video

image

Related Issues and/or PRs

Todos

  • Tests
  • Documentation
PareshRadadiya added a commit to PareshRadadiya/gutenberg that referenced this issue Nov 18, 2017
@PareshRadadiya
Remove top link from embedded content block fix WordPress#3497
041faab
@PareshRadadiya PareshRadadiya mentioned this issue Nov 18, 2017
Closed
@swissspidy
Copy link
Member

Check out http://develop.svn.wordpress.org/branches/4.9/src/wp-includes/js/wp-embed.js for how these embeds should be handled.

Probably just need to embed this script. It does a bit more than just 041faab.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media labels Nov 20, 2017
@aduth
Copy link
Member

aduth commented Mar 1, 2018

@swissspidy @imath Can this be considered closed by #4226?

@aduth aduth added the [Status] Needs More Info Follow-up required in order to be actionable. label Mar 1, 2018
@imath
Copy link
Contributor

imath commented Mar 1, 2018

Hi @aduth Yes, the top link is no more showing now.

@MaxMood96 MaxMood96 mentioned this issue Dec 20, 2023
Open
@naiba4 naiba4 mentioned this issue Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove top link from embedded content block fix #3497 PareshRadadiya/gutenberg
5 participants
@mtias @swissspidy @aduth @imath @darrencoutts118