Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile]: Split pasted content correctly between title and body #35733

Closed
guarani opened this issue Oct 18, 2021 · 5 comments
Closed

[RNMobile]: Split pasted content correctly between title and body #35733

guarani opened this issue Oct 18, 2021 · 5 comments
Assignees
@derekblank
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.

Comments

@guarani
Copy link
Contributor

guarani commented Oct 18, 2021 •
edited
Loading

What problem does this address?

In the native mobile editor, it's not possible to paste content into the editor title field and have it split correctly between the title and body.

Web Native Mobile
Screen recording showing how pasted text in the title field of the web editor is split correctly between title and body Screen recording showing how pasted text in the title field of the native mobile editor is not split correctly between title and body

What is your proposed solution?

Just like on the web, content pasted into the title field should split correctly between the title and body. It might be reasonable to put whatever follows the first new-line character in the body, keeping what's before it in the title. That said, there might be a web implementation we can use to avoid re-implementing this.
@guarani guarani added [Type] Enhancement A suggestion for improvement. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Oct 18, 2021
@mchowning mchowning added the [Priority] High Used to indicate top priority items that need quick attention label Oct 19, 2021
@mchowning
Copy link
Contributor

mchowning commented Oct 19, 2021 •
edited
Loading

I'm a bit torn on what priority to give this. It feels like a bit of an edge case, but it's not that much of an edge case, and it is really annoying when it happens because of how jarring it feels. For that reason I'm marking it as high priority, but definitely open to other opinions.

@guarani guarani self-assigned this Dec 2, 2021
@guarani
Copy link
Contributor Author

guarani commented Dec 2, 2021

Assigning myself to work on it next week.

@guarani guarani mentioned this issue Dec 8, 2021
Closed
2 tasks
@derekblank
Copy link
Member

Hello 👋 I'm happy to take a look at this one.

@derekblank
Copy link
Member

I can confirm that @guarani 's changes in #37169 resolve the issue for both platforms for all test cases. 🎉

I'll get the CI and merge conflicts in the related PRs to pass so we can merge them and close this issue. 👍

Split.Paste.mov

@derekblank
Copy link
Member

The issue fix has been merged. 🏁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekblank derekblank

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split pasted content between title and body wordpress-mobile/gutenberg-mobile
3 participants
@derekblank @guarani @mchowning