[RNMobile] Split pasted content between title and body #37169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
Testing commit 2d847e2 on both the iOS and Android demo apps:
The text I pasted in to the editor to test this is found here: https://wordpress.org/news/2021/11/state-of-the-word-2021. I copied the text starting from "Howdy, World!" up to and including "Word 2021!". The "image followed by text" I used in the above test is found here: https://wordpress.org/support/article/how-to-use-gravatars/#what-is-a-gravatar
|
2 tasks
guarani
changed the title
guarani
force-pushed
the
rnmobile/fix/paste-in-title
branch
from
2d847e2 to
5e4cd27
Compare
jhnstn
reviewed
Dec 14, 2021
| if ( typeof content === 'string' ) { | ||
| const valueToInsert = create( { html: content } ); | ||
| onChange( insert( value, valueToInsert ) ); | ||
| if ( typeof content !== 'string' && content.length ) { |
There was a problem hiding this comment.
I was curious about what happens when pasting a string since it looks like that is no longer handled.
So far I have only tested Android, pasting blocks works fine but a non block paste does not:
paste-android.mp4
There was a problem hiding this comment.
I am on Android 12 , Pixel 5
There was a problem hiding this comment.
Thanks for catching this 🤦. I forgot the most straightforward case.
37 tasks
derekblank
added
the
Mobile App - Automation
|
Flaky tests detected in 2c3b298. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4685002483
|
derekblank
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Nice work @guarani! I can confirm this resolves the issue through the test cases mentioned in this comment. Approving and merging. 🚀
|
Thanks for helping get this across the line @derekblank! ❤️ |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #21758, when pasting content into the post title, split pasted content between title and body.
Related:
Split pasted content between title and body wordpress-mobile/gutenberg-mobile#4350How has this been tested?
I ran through the following test cases (see comment below):
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).