Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block - Default overlay opacity is set to 100 #35766

Closed
geriux opened this issue Oct 19, 2021 · 2 comments · Fixed by #35792 or #35789
Closed

Cover block - Default overlay opacity is set to 100 #35766

geriux opened this issue Oct 19, 2021 · 2 comments · Fixed by #35792 or #35789
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@geriux
Copy link
Member

geriux commented Oct 19, 2021

Description

The default overlay opacity is set to 100 which covers any image/video that's added as a background. This is a regression from this PR.

Step-by-step reproduction instructions

  • Open the mobile editor
  • Add a Cover block
  • Add an image
  • Once it finishes uploading, you can see the overlay is covering the image.

Expected behaviour

The media should be visible when it's added to the block. The overlay should have a default value of 50

Actual behaviour

The media is covered by the overlay which has a default value of 100

Screenshots or screen recording (optional)

Screenrecorder-2021-10-19-16-46-05-405.mp4

Device information

  • Device: Redmi Note 8T OS 11
@geriux geriux added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Oct 19, 2021
@glendaviesnz glendaviesnz self-assigned this Oct 20, 2021
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Oct 20, 2021

@geriux Because of the need to allow an opacity setting on the background color when there is no image, as added here, I think it might be confusing to users to set the default dimRatio to 50 as then the background color will have a default 0.5 opacity so users might wonder why they selected black but it shows more as a grey, etc.

It would be possible though to switch the dimRatio to 50 if an image is added and it is currently set to 100 as in this PR. Do you think that would work as a solution for the mobile app as well?

@geriux
Copy link
Member Author

geriux commented Oct 20, 2021

@geriux Because of the need to allow an opacity setting on the background color when there is no image, as added here, I think it might be confusing to users to set the default dimRatio to 50 as then the background color will have a default 0.5 opacity so users might wonder why they selected black but it shows more as a grey, etc.

It would be possible though to switch the dimRatio to 50 if an image is added and it is currently set to 100 as in this PR. Do you think that would work as a solution for the mobile app as well?

Hey @glendaviesnz 👋 thank you for working on a fix so quickly! This works for mobile with the extra change from this PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
2 participants