-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover block: Change dimRatio to 50 if media added and dimRatio is set to 100 #35789
Conversation
…ent background color obscuring image
Size Change: +25 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @glendaviesnz 👋
Thank you for fixing this so quickly. The solution LGTM and works as expected 🎉
I've made a small change with #35792 to make the PR to work on mobile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested it on mobile with different scenarios and it's working as expected. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @glendaviesnz 👋
after @geriux's approval I tool the liberty to merge the mobile fix into this PR. Everything works as expected now on mobile too 🎉
Hey @glendaviesnz I'll merge this PR so we can move forward with the beta fix of the app. 🙇 |
* Release script: Update react-native-editor version to 1.64.0 * Release script: Update with changes from 'npm run core preios' * Update Changelog * Release script: Update react-native-editor version to 1.64.1 * Release script: Update with changes from 'npm run core preios' * Fix updating the block list after block removal (#35721) * Cover block: Change dimRatio to 50 if media added and dimRatio is set to 100 (#35789) * Change opacity to 50 if media added and opacity is set to 100 to prevent background color obscuring image * Fixes cover opacity bug on mobile (#35792) Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> * Mobile - Update Changelog Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com>
Description
Changes the dimRation to 50 if media added and dimRatio is set to 100 to prevent background color obscuring image
Potential fix for: #35766
To test
Screenshots
Before:
After: