Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added by column shows an empty grey circle for old templates if the site has no logo #37086

Closed
talldan opened this issue Dec 3, 2021 · 4 comments · Fixed by #37474
Closed
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Dec 3, 2021

Description

This issue follows up on what @paaljoachim mentioned here - #36763 (comment)

The Added By column can show an empty dark grey circle in some situations.

It requires a very specific scenario. The user needs to have created the template or template part before author support was added to templates. This causes the site logo and name to display as a fallback. If the site has no logo, this is when a grey circle is shown.

It's a pretty easy to show an icon as a fallback, so we should do it. Just need to know which icon to use 😄

Step-by-step reproduction instructions

Testing is pretty difficult since it requires either existing old templates or for you to create a new template using an old version of WordPress and Gutenberg (maybe something like WP 5.8.2 and 11.9)

  1. Remove any site logo
  2. Create a template or template part
  3. View the template or template part in the list

Screenshots, screen recording, code snippet

Screenshot 2021-11-26 at 13 03 40

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Dec 3, 2021
@paaljoachim
Copy link
Contributor

I would suggest using the W as a fallback icon.

W-placeholder-icon

@jameskoster
Copy link
Contributor

Hmm, might the W icon might lead folks to believe that the template was added by WordPress itself (kind of like a default) rather than created from scratch by a user?

Other potential options to consider – globe or comment-author-gravatar:

Screenshot 2021-12-03 at 10 39 45

@paaljoachim
Copy link
Contributor

Hmm, might the W icon might lead folks to believe that the template was added by WordPress itself (kind of like a default) rather than created from scratch by a user?

Good point!

The comment-author-gravatar seems like a good icon to add. It signals that the template was added by a user.

@jameskoster
Copy link
Contributor

It's a little strange to have a person icon coupled with the site name, but it's probably ok since this is a corner case.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 17, 2021
@talldan talldan removed the Needs Design Feedback Needs general design feedback. label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants