Fix empty gray circle when site has no logo on template list page #37474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
talldan
added
[Feature] Site Editor
|
Size Change: +376 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
talldan
changed the title
talldan
changed the title
|
I followed the testing instructions and the globe icon is showing correctly. Of course, the conflict has to be solved too. |
Fix handling of unresolved site Use globe icon Enforce single child for tooltip by using ternary
talldan
force-pushed
the
fix/empty-grey-circle
branch
from
ca282bb to
3ecb8f4
Compare
talldan
added
Backport to WP Minor Release
talldan
requested review from
Mamaduka,
Aljullu and
kevin940726
and removed request for
Mamaduka
|
Cherry-picked for the minor. |
Mamaduka
removed
the
Backport to WP Minor Release
Mamaduka
pushed a commit
that referenced
this pull request
Feb 16, 2022
…7474) * Refactor and show icon in place of missing site logo Fix handling of unresolved site Use globe icon Enforce single child for tooltip by using ternary * Fix handling of missing avatar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37086
Usually the template list page will show the author details for a custom template, but for older versions of WordPress/Gutenberg some templates may have been created before templates had author support.
In those cases there's a fallback to displaying the site logo and name. But if the user doesn't have a site logo set, then we need a fallback for the fallback, which would be to show an icon (the Globe icon).
How has this been tested?
This is a little hard to test, because you need to create a template or template part using an old version of WordPress and Gutenberg, and then update.
I found it easier to add a little hack into the code to test it:
AddedBycomponent, after the early return add the following -template.author = undefined;Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).