Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom sheet: Long labels make items to be cut off [only on Android] #37858

Closed
fluiddot opened this issue Jan 11, 2022 · 2 comments · Fixed by #37993
Closed

Bottom sheet: Long labels make items to be cut off [only on Android] #37858

fluiddot opened this issue Jan 11, 2022 · 2 comments · Fixed by #37993
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

Description

On Android when an item (cell component) of a bottom sheet contains a long label, the content of the item gets cut off. I managed to reproduce this when setting the device's locale to Spanish and opening the block settings of an Embed block.

NOTE: On iOS this behavior can't be reproduced so this issue is specific to Android.

Step-by-step reproduction instructions

Preparation:
Since this issue can only be reproduced on Android, so an Android device/emulator is required for testing it.

  1. Change the device's locale to Spanish (any language that usually requires more space than English should work, i.e. Spanish, Portuguese or French).
  2. Open a post/page.
  3. Add an Embed block.
  4. Set a YouTube URL (example: https://www.youtube.com/watch?v=ssfHW5lwFZg), this is required to display the media settings.
  5. Open the block settings.
  6. Observe that the item with the label "Resize for smaller devices" (the first one under the Media settings section) is cut off.

Expected behaviour

Items within the bottom sheet modals should display their entire content.

Actual behaviour

Items within the bottom sheet modals can be cut off if they have a long label.

Screenshots or screen recording (optional)

Android (content is cut off):

Screenshot Video capture
android-item-cut-off.mp4

iOS (content is NOT cut off):

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: Samsung Galaxy S20 FE 5G
  • Operating system: Android 11
  • WordPress app version: 18.9 (1148)
@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jan 11, 2022
@mchowning mchowning added the [Priority] High Used to indicate top priority items that need quick attention label Jan 11, 2022
@hypest
Copy link
Contributor

hypest commented Jan 14, 2022

👋 @dcalhoun , you probably have some bandwidth available to dive into this issue? Let me know if this doesn't lend itself too much for you picking it up. Thanks!

@dcalhoun
Copy link
Member

👋 @dcalhoun , you probably have some bandwidth available to dive into this issue? Let me know if this doesn't lend itself too much for you picking it up. Thanks!

@hypest yep! Happy to work on addressing this issue.

@dcalhoun dcalhoun self-assigned this Jan 14, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants