Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple color palettes on Mobile #38525

Closed
geriux opened this issue Feb 4, 2022 · 2 comments · Fixed by #38417 or wordpress-mobile/gutenberg-mobile#4588
Closed

Support multiple color palettes on Mobile #38525

geriux opened this issue Feb 4, 2022 · 2 comments · Fixed by #38417 or wordpress-mobile/gutenberg-mobile#4588
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Design Needs design efforts.

Comments

@geriux
Copy link
Member

geriux commented Feb 4, 2022

Description

On mobile, we are working on adding support for multiple color palettes in #38417.

Users can now create their own colors that would be shown in a Custom palette. So we'll have Theme and Default and the Custom palette will be shown if users add new colors.

The initial implementation is merging all palettes into one row, but it was mentioned from the code review feedback to maybe do something similar to the way the web editor does it:

On mobile we currently have one row of colors:

@iamthomasbishop I was wondering if you had any design ideas about this since we've only had one row of colors until now. The functionality would be as it was before, you can only select one color at a time. Thank you!

@geriux geriux added Needs Design Needs design efforts. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Feb 4, 2022
@iamthomasbishop
Copy link

@geriux I think we could separate them similarly into sections, each section with a leading section header. Would something along the lines of this make sense?

One other thing, which isn't directly related to this, but has me wondering: As far as I know, we don't currently support saving multiple "custom" colors on mobile (at least directly in the editor UI). Is the idea that we'd just show the custom color swatches that the user has already saved via the web UI?

@geriux
Copy link
Member Author

geriux commented Feb 7, 2022

@geriux I think we could separate them similarly into sections, each section with a leading section header. Would something along the lines of this make sense?

It does, thank you for the mockup!

Is the idea that we'd just show the custom color swatches that the user has already saved via the web UI?

That's correct, users won't be able to edit/customize them within the mobile editor.

Thanks again Thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Design Needs design efforts.
Projects
None yet
2 participants