Fix Custom Palette colors and support multiple origins and theme cache issues #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2022 09:45
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
I saw that unit tests are also failing in #4586, so looks like we have an actual breakage here due to recent changes in Gutenberg |
Thanks for working on the fix for that 🎉 I updated this PR and it will only update the release notes since the Gutenberg reference was already updated 👍 |
I was about to notify you that the fix is already merged 😅, glad to know that it worked. |
fluiddot
approved these changes
Feb 16, 2022
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Mar 7, 2022
The PR originally linked was closed, wordpress-mobile/gutenberg-mobile#4537 , in favor of the new one, wordpress-mobile/gutenberg-mobile#4588 . While it was easy enough to find the latter by reading through the conversation in the former, I decided to bypass that to remove friction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> Fix Custom Palette colors and support multiple origins and theme cache issues. WordPress/gutenberg#38417Fixes WordPress/gutenberg#38525 and WordPress/gutenberg#36152
This is a follow-up of WordPress/gutenberg#38474
Description
This PR fixes several issues, first, it fixes an ongoing issue where changing between themes would not refresh the current theme data and a restart of the editor was needed, as well as sometimes opening the editor for the first time and not seeing the theme colors.
Second, it adds support for multiple color and gradient palettes including the
Customones.To test check the Gutenberg PR description.
PR submission checklist: