Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'open in new tab' option gets auto unchecked when editing the link of the 'linkeded text' in 'paragraph block' #42080

Closed
hz-tyfoon opened this issue Jun 30, 2022 · 2 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@hz-tyfoon
Copy link
Contributor

hz-tyfoon commented Jun 30, 2022

Description

When using the paragraph block. If I make some text in the paragraph 'linkable' and make the link 'open in new tab' checked, then after I decide to change the link url and hit the 'submit button/curved arrow' then the link's 'open in new tab' option gets auto unchecked.

See the 'Step-by-step reproduction instructions' & the 'screen recording' for more details.

Step-by-step reproduction instructions

  1. Take the paragraph block with some texts.
  2. Select some text from the paragraph & from the options over the selected texts click the 'link' button (located in between the 'italic' (I) and the 'more'/'arrow down' button) to make the selected text linkable.
  3. give any url in the poped up input field and 'check' the 'open in new tab' option and save it by clicking the submit (the curved arrow on right side of the input field) button
  4. now click somewhere else (or update the page then reload the page) and then the click the linked text again to edit the url
  5. now change the url and press the submit button again.
  6. Now U'll see that the link's 'open in new tab' option is also unchecked if U click the linked text again

See the video for better understanding

Screenshots, screen recording, code snippet

open_in_new_tab_issue.mp4

Environment info

Wordpress version 6.0

gutenberg v13.5.2 (latest) also same on the current 'trunk' branch of github (I've checked)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@hz-tyfoon
Copy link
Contributor Author

hz-tyfoon commented Jun 30, 2022

PR: #42073 fixs this issue

@talldan talldan added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Jul 5, 2022
@talldan
Copy link
Contributor

talldan commented Jul 5, 2022

This was previously reported (#40243), so I'll close this.

@talldan talldan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

2 participants