Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When editing a link in a button block, linkTarget is reset even though only the url is changed. #40243

Closed
ddryo opened this issue Apr 12, 2022 · 1 comment · Fixed by #42073
Closed

When editing a link in a button block, linkTarget is reset even though only the url is changed. #40243

ddryo opened this issue Apr 12, 2022 · 1 comment · Fixed by #42073
Assignees
@ddryo

Comments

@ddryo
Copy link
Contributor

ddryo commented Apr 12, 2022 •
edited
Loading

Description

Kapture.2022-04-12.at.12.06.21.mp4

Step-by-step reproduction instructions

  1. Set up a button block.
  2. Set the URL for the link and turn on "Open in new tab".
  3. Edit the URL using the "Edit" button and click the "Submit" button to save.
  4. Then "Open in new tab" will be turned off.

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress 5.9.3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@ddryo ddryo mentioned this issue Apr 12, 2022
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 12, 2022
ddryo added a commit to ddryo/gutenberg that referenced this issue Apr 12, 2022
@ddryo
fix handleSubmit of LinkControl (WordPress#40243)
2b8acc7
@joashrajin joashrajin mentioned this issue May 6, 2022
Closed
@hz-tyfoon hz-tyfoon mentioned this issue Jun 30, 2022
Merged
@hz-tyfoon
Copy link
Contributor

Looks like This issue is simillar to (issue: #42032)
And can be fixed also by (PR #42073)

@talldan talldan mentioned this issue Jul 5, 2022
Closed
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddryo ddryo

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@priethor @ddryo @hz-tyfoon