-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile UI for moving blocks, switching type, and formatting #44
Comments
@jasmussen great prototypes! I think that the first one is better, for two main reasons:
By the way, keeping the formatting options "attached" to the keyboard feels more intuitive. |
Great thoughts @diegoliv. I do completely agree with having navigation bottom-side when possible, which is why that was my first instinct also. However @Afraithe reminded me that it isn't actually possible to know when the soft-keyboard is open on mobile, and so we can't actually calculate where to place the bottom toolbar. To put it differently, if we added If we were building an app it would be a different thing of course :D If new developments have happened in the mobile CSS space, would be cool to revisit this, but I think sadly we're stuck with a top-bound toolbar for now. |
Hey @jasmussen, thx for the mobile mocks! May I ask, do I read it correctly that the block/inline formatting options only appear when text is already selected? |
Something to explore when we get to this point, probably. Alternatively they could be grayed out. |
@jasmussen This looks great!
I'd love to make sure this is (still) true. Seems the problem is iOS Safari wasn't always adjusting the viewport correctly. I'd love to find out if that's been fixed… maybe I'll make an attempt at it. |
😍 There's a 🌟 emoji in it for you! |
@nheagy the last time I worked on this, the first challenge was that Android Chrome and Mobile Safari behave differently:
Secondly, as Joen said, it's quite hard to determine if the device has the keyboard shown at all. There are also cases when the keyboard is "shown" but it is not actually visible, such as when an external bluetooth keyboard is being used. All of which is to say that I think it's still a good idea in the current state of the web to use top-fixed elements whenever possible. |
A summary of where TinyMCE is headed with mobile capability (and what we learned from making Textbox.io, a fully accessible, professional quality text editor for mobile) |
Closing this in favor of individual tickets: https://github.com/WordPress/gutenberg/labels/%5BComponent%5D%20Mobile |
Steps to reproduce:
Result: the options to move a block seem to be hidden off-left. (14s) I expected to be able to drag and drop the content blocks from an edit mode of some sort, as #38 suggests.
Tested with Chrome on a Pixel with Android 7.1.1.
The text was updated successfully, but these errors were encountered: