-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Header & Footer patterns use the Pattern Directory API #46017
Comments
@beafialho let me know the patterns are submitted and pending approval! Going to cross that off for now. |
Should we consider them If we want them completely separate I can implement the function to make a new request. |
I'm happy to make those changes in the pattern directory, just let me know which term (the hidden one, core or public-facing, featured) is decided :) |
AFAIK these patterns should be listed as "featured" since they are meant for use on all sites and are curated by WPORG (partially based on this convo WordPress/pattern-directory#542 ) @jasmussen can you confirm this? I want to ensure I have this absolutely correct. |
I could be missing a few beats here, so forgive me if I'm restating things already noted, but my understanding is that this needs to consider the new structure outlined in #44501. Which is a meta-split into two major categories, Featured and Community. Featured are all from the WP.org user, Community is everything else. Both of those meta-categories are sub-categorized into the noted buckets, and I would imagine the "Header" and "Footer" categories being used for these. |
Let's try to clarify the end goal here, because some of the mentioned things by me are technicalities.
Just curious how this is going to affect Gutenberg. In my mind we would still have the pattern categories in the inserter and where else we use them, but we might use that |
To clarify, Community and Featured tabs are both available in the pattern directory. But only patterns from the Featured tab show up in the pattern explorer (#44611). There's a doodle of how those tabs could look in WordPress/pattern-directory#395 (comment) — it's not a final design by any means, I would hope we can make it much more compact and simple. But hopefully it shows the split. |
Sorry but still it's not 100% clear to me what we want for Gutenberg. If I understand correctly the meta I think the confusion comes with having a The goal for this issue is to simply fetch these So, right now these patterns don't have the |
Right, sorry for the detour, yes! Mainly I wanted to be sure that those bundled header and footer patterns are only sourced from the wp.org user, so we don't suddenly have thousands of options to scroll through in the "Replace" flow 😅 |
By default yes, any patterns tagged |
@ryelle can we tag them as |
@ryelle when you find some time and update the patterns, please share, in order to open a PR to handle the GB side. Thanks! |
Noting that there's a PR in place to remove the bundled patterns & load them appropriately from the pattern directory #46450 This is currently on hold though until the patterns listed here are recategorized and a problem with patterns with the navigation block is resolved. |
With the current implementation of the registration of patterns and the change of the above patterns to be That means that if we don't find a solution for WordPress/pattern-directory#545 in time for |
While we have an in between solution in place for now with the bundled header & footer patterns #44843 (comment), the following still needs to be done to close out efforts here. This is a quick, new issue to ensure that work continues forward.
Desired outcome:
Header and Footer patterns are in the pattern directory and pulled in from there rather than being bundled. The bundling was a temporary measure that we need to follow up on.
Next steps:
For the latter, want to note the following from @ryelle around how to do so -- "either with a new API request with specific slugs, or by adding these to the featured category to auto-load them on all sites"
The text was updated successfully, but these errors were encountered: