-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The table block footer section is not displaying properly. #46183
Comments
Hey @t-hamano 👋 To display the footer section the same as the header section, I have added the same style as Here is the output for the same: Let me know if it is the right implementation. Thanks. |
@viralsampat-multidots I saw your video and the borders below the In your video, this border disappears on the front end, but the latest Gutenberg trunk appears to have resolved this issue. This should not be a problem in themes that support block styles, since However, in themes without block styles like TT3, there remains the problem of not being able to visually identify where the footer is. To solve this problem, @devanshijoshi9 tried the approach of making the @mikachan @aaronrobertshaw @alexstine |
@joedolson Maybe some visual feedback you can provide? |
Thanks for the ping 👍 I gave this a bit of a test and witnessed the same behaviour, and came to the same conclusions as @t-hamano.
To play devil's advocate for a moment, it could also be possible to view the footer's lack of distinction as a visual bug or accessibility issue. Depending on how subtle any styling tweaks were, they might be a welcome change. That said, I don't have a strong opinion in this case, but I would likely lean towards not introducing anything potentially breaking as well. There’s also been some long running discussion around improving the Table block, including refactoring it to use inner blocks which would provide a huge increase in terms of what we could control and style. The downside there is any change on that front is going to be slow as its a huge and complex job. |
Overall, I'd like to see the table block refactored so that it offers a better overall experience. The biggest problem I can see with the lack of a visually distinct demarcation of That may be obvious when you create the block, but not necessarily to a second editor who comes in to make changes, later. I'd consider the lack of distinction to be a bug. |
Thanks for your input, @aaronrobertshaw, @joedolson. For the moment, I have added this issue as a bug in the tracking issue. (possibly an enhancement). Also, @viralsampat-multidots has submitted #46567, which seems to offer a solution that includes making the font-weight thicker. |
Can we close this one since #46567 has landed? |
@ntsekouras In #46567, I would like to close this issue, but if I have missed something please comment. Twenty Twenty Three: Twenty Twenty One: |
What problem does this address?
I have checked Gutenberg table block and I have added its header section, test data, and footer section. But, in admin and at front-end user can't identify that which is footer section. Because footer section is react like row & columns data.
For better understanding here I have attached video for the same.
Video
What is your proposed solution?
Here, I have one suggestion like if possible then we can modified footer section like our header section, If we will display like our header section. So user can easily identify that here we have footer section.
The text was updated successfully, but these errors were encountered: