Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page List allows convert to links with no Page data #46301

Closed
getdave opened this issue Dec 5, 2022 · 0 comments · Fixed by #46331
Closed

Page List allows convert to links with no Page data #46301

getdave opened this issue Dec 5, 2022 · 0 comments · Fixed by #46331
Assignees
@draganescu
Labels
[Block] Page List Affects the Page List Block [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Dec 5, 2022

The Page List block allows for converting into Navigation links when it is a child of the Nav block.

However if you have no Pages on your site this flow breaks down. The convert option is displayed and you can convert the links but nothing happens and you get no feedback. The Page List remains "as is".

We should hide the Edit button in this case.

Screen.Capture.on.2022-12-05.at.10-04-09.mp4
@getdave getdave added [Type] Bug An existing feature does not function as intended [Block] Page List Affects the Page List Block labels Dec 5, 2022
@draganescu draganescu self-assigned this Dec 6, 2022
@draganescu draganescu mentioned this issue Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draganescu draganescu

Labels
[Block] Page List Affects the Page List Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Page List Block: Hide page list edit button if no pages available WordPress/gutenberg
2 participants
@draganescu @getdave