Page List Block: Hide page list edit button if no pages available #46331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
draganescu
changed the title
draganescu
changed the title
|
Size Change: +2 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
I noticed that when there are no pages you get an extra BlockControls:
I added a commit to also hide the BlockControls:
|
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* hides page list edit button if no pages avaulable * Don't output BlockControls if there are no pages Co-authored-by: Andrei Draganescu <github@andreidraganescu.info> Co-authored-by: Ben Dwyer <ben@scruffian.com>
ryanwelcher
changed the title
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #46301
Why?
When the page list has no pages to retrieve, clicking "edit" when the block is a child of navigation is confusing as nothing really happens.
How?
Only show the button if there are pages.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A