Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Offcanvas to programmatically retrieve the last inserted block #46532

Closed
getdave opened this issue Dec 14, 2022 · 1 comment
Closed
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Experimental Experimental feature or API.

Comments

@getdave
Copy link
Contributor

getdave commented Dec 14, 2022

Currently the appender in the offcanvas uses a callback approach to retrieve the ID of the block that has just been inserted.

This is confusing, requires a lot of prop drilling and breaks the Redux paradigm.

In #46531 I'm proposing a selector to retrieve the ID of the last inserted block. Once that lands we can refactor the offcanvas implementation to use the selector and remove all the callback stuff.

@getdave getdave self-assigned this Dec 14, 2022
@getdave getdave added [Block] Navigation Affects the Navigation Block [Type] Experimental Experimental feature or API. labels Dec 14, 2022
@getdave
Copy link
Contributor Author

getdave commented Jan 9, 2023

This has been implemented.

@getdave getdave closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Experimental Experimental feature or API.
Projects
None yet
Development

No branches or pull requests

1 participant