Add new selector getLastInsertedBlockClientId #46531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
getdave
requested review from
scruffian,
MaggieCabrera,
ajlende and
draganescu
This was referenced Dec 14, 2022
|
Size Change: +31 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Hey folks, is this something you plan to use in a PR or something, it's hard to judge of the usefulness of a new stable API without context. I don't see it used on the linked PR |
|
If you look at the "future plans" part of that PR, it should explain the reasoning. I'm going to try to implement that... |
|
Followup PR here: #46744 |
@youknowriad This was an oversight on my part. I believe it should have been experimental to start with. This has now been proven by the need to raise this PR which I'd very much appreciate your review on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new selector for retrieving the
clientIdof the last inserted block.Why?
Some implementations do not select the block following insertion. Indeed this eventuality is catered for by the 4th argument of
insertBlocks.Therefore it is important to have some means of programmatically retriving the ID of the last block that was inserted.
A case in point is the work being undertaken in the Nav block offcanvas experiment where we do not wish to immediately select a block that has been inserted as that would cause the inspector controls to switch away from those of the Navigation block which is where the offcanvas is rendered.
See #46503
How?
Adds selector and tests. Luckily the actions and reducer were already part of the code.
Testing Instructions
Run tests with
Testing Instructions for Keyboard
Screenshots or screencast