Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Importer: Extra "import" button visible when there's nothing to import #47982

Closed
annezazu opened this issue Feb 10, 2023 · 2 comments · Fixed by #48396
Closed

Widget Importer: Extra "import" button visible when there's nothing to import #47982

annezazu opened this issue Feb 10, 2023 · 2 comments · Fixed by #48396
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

When there's nothing to import and you add a new template part, an extra "import" option appears that is always in a disabled state.

I also noticed the import option is under "Advanced" rather than at a top line level. This feels a bit hidden and I'm not sure why/where that decision was made but wanted to note!

Step-by-step reproduction instructions

  1. Create a new site using a block theme.
  2. Open the Appearance > Editor.
  3. Add a new template part.
  4. Notice there's an import button visible despite there being nothing to import.

Screenshots, screen recording, code snippet

When there's nothing to import:
https://user-images.githubusercontent.com/26996883/218203172-e6332fe2-458d-41cc-95ef-4e299a274b0a.mov

When there's something to import:

Screen Shot 2023-02-10 at 1 35 01 PM

Environment info

  • WordPress 6.2 beta 1
  • No GB installed
  • TT3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 10, 2023
@annezazu annezazu moved this to 📥 Todo in WordPress 6.2 Editor Tasks Feb 10, 2023
@annezazu
Copy link
Contributor Author

Noting that this still appears with beta 3 but it has slightly changed:

Screen Shot 2023-02-23 at 10 08 35 AM

@Mamaduka
Copy link
Member

I’ve a potential fix and will push it tomorrow.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 24, 2023
@Mamaduka Mamaduka moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.2 Editor Tasks Feb 24, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.2 Editor Tasks Feb 24, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants