Widget Importer: Don't render controls when there's nothing to import #48396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
ntsekouras and
annezazu
and removed request for
ajitbohra
Mamaduka
force-pushed
the
fix/widget-importer-empty-state
branch
from
3521d72 to
4a8ef09
Compare
Mamaduka
commented
Feb 24, 2023
packages/block-library/src/template-part/edit/import-controls.js
Outdated
Show resolved
Hide resolved
|
Size Change: +395 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
|
Flaky tests detected in bb2a37c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4260723844
|
ntsekouras
reviewed
Feb 24, 2023
packages/block-library/src/template-part/edit/import-controls.js
Outdated
Show resolved
Hide resolved
ntsekouras
approved these changes
Feb 24, 2023
packages/block-library/src/template-part/edit/import-controls.js
Outdated
Show resolved
Hide resolved
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: eec1d09 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #47982.
PR updates the
TemplatePartImportControlsto not render controls when there's nothing to import.Testing Instructions
Make sure there're no "Widget Areas" to import. For example, running the following command should work for testing:
Screenshots or screencast
CleanShot.2023-02-23.at.21.59.49.mp4