Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should not allow blocks to be moved #48278

Closed
github-actions bot opened this issue Feb 21, 2023 · 3 comments
Closed

[Flaky Test] should not allow blocks to be moved #48278

github-actions bot opened this issue Feb 21, 2023 · 3 comments
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Feb 21, 2023

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should not allow blocks to be moved

Test path

specs/editor/plugins/cpt-locking.test.js

Errors

[2023-02-21T12:23:11.077Z] Test passed after 3 failed attempts on try/duotone-custom-properties.
[2023-03-07T12:02:36.964Z] Test passed after 5 failed attempts on try/dedicated-block-controls-filter.
[2023-04-26T07:02:32.598Z] Test passed after 3 failed attempts on add/editor-content-only-lock.
[2023-04-27T14:33:19.010Z] Test passed after 3 failed attempts on add/block-variation-transforms-in-switcher.
[2023-05-04T08:31:07.359Z] Test passed after 3 failed attempts on add/block-variation-transforms-in-switcher.
[2023-06-09T14:22:46.868Z] Test passed after 3 failed attempts on add/custom-attribute-sources.
[2023-06-11T10:27:34.189Z] Test passed after 3 failed attempts on try/block-editor-block-settings-dropdownmenu-v2.
[2023-06-12T07:40:34.204Z] Test passed after 3 failed attempts on try/block-editor-block-settings-dropdownmenu-v2.
[2023-06-12T11:42:31.900Z] Test passed after 3 failed attempts on add/custom-attribute-sources.
[2023-07-02T10:56:32.583Z] Test passed after 3 failed attempts on update/sort-is-stable.
[2023-07-10T10:46:47.446Z] Test passed after 3 failed attempts on update/sort-is-stable.
[2023-09-19T21:17:54.652Z] Test passed after 3 failed attempts on try/droprown-v2-ariakit-test.
[2023-09-22T17:17:55.039Z] Test passed after 3 failed attempts on try/droprown-v2-ariakit-test.
[2023-09-25T22:04:08.200Z] Test passed after 3 failed attempts on try/droprown-v2-ariakit-test.
[2023-09-26T11:52:24.556Z] Test passed after 3 failed attempts on try/droprown-v2-ariakit-test.
[2023-09-26T14:22:13.924Z] Test passed after 3 failed attempts on try/droprown-v2-ariakit-test.
[2023-11-11T00:16:42.555Z] Test passed after 3 failed attempts on trunk.
[2023-11-11T01:57:56.983Z] Test passed after 3 failed attempts on try/customselect-ariakit.
[2023-11-11T11:02:53.095Z] Test passed after 3 failed attempts on try/pass-rich-text-value-to-store.
  ● cpt locking › template_lock all › should not allow blocks to be moved

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["ReferenceError: selectedBlockClientId is not defined

      at zI (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=ee0fd2bbed58ad5b8877:148:130)
      at St (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:47627)
      at $s (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:120574)
      at Sl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88649)
      at kl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88577)
      at bl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88440)
      at sl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:85264)
      at dl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:85651)
      at Nn (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:32464)
      at ../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:83216"]
      console.error() should not be used unless explicitly expected
      See https://www.npmjs.com/package/@wordpress/jest-console for details.

  ● cpt locking › template_lock all › should not allow blocks to be moved

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["ReferenceError: selectedBlockClientId is not defined

      at zI (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=ee0fd2bbed58ad5b8877:148:130)
      at St (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:47627)
      at $s (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:120574)
      at Sl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88649)
      at kl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88577)
      at bl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88440)
      at sl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:85264)
      at dl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:85651)
      at Nn (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:32464)
      at ../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:83216"]
      console.error() should not be used unless explicitly expected
      See https://www.npmjs.com/package/@wordpress/jest-console for details.
          at runMicrotasks (<anonymous>)

  ● cpt locking › template_lock all › should not allow blocks to be moved

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["ReferenceError: selectedBlockClientId is not defined

      at zI (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=ee0fd2bbed58ad5b8877:148:130)
      at St (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:47627)
      at $s (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:120574)
      at Sl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88649)
      at kl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88577)
      at bl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88440)
      at sl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:85264)
      at dl (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:85651)
      at Nn (../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:32464)
      at ../../http:/localhost:8889/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:83216"]
      console.error() should not be used unless explicitly expected
      See https://www.npmjs.com/package/@wordpress/jest-console for details.
          at runMicrotasks (<anonymous>)

@github-actions
Copy link
Author

github-actions bot commented Jun 4, 2023

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jun 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
@github-actions github-actions bot reopened this Jun 9, 2023
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jun 10, 2023
@github-actions github-actions bot reopened this Jul 2, 2023
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 13, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
@github-actions github-actions bot reopened this Sep 19, 2023
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Sep 21, 2023
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
@github-actions github-actions bot reopened this Nov 11, 2023
github-actions bot referenced this issue Nov 11, 2023
The Top Toolbar was relying on position: absolute; CSS and layoutEffect calculations to display the selected block tools visually within the top toolbar. This PR places it in the header DOM where we want it, allowing us to use native CSS and DOM flow to improve accessibility (tab order matches visual order) and have more maintainable code.

* Imports `<BlockContextualToolbar />` via private-api and the <Popover /> for image captions to the edit site, edit post, edit widgets, and customize widget headers.
* Removes position: absolute; and layoutEffect block toolbar positioning hacks.
* CSS for the top toolbar to use flex-shrink and overflow-x: hidden; to allow for the block toolbar to fit its current space and scroll to reveal the hidden tools.
* With top toolbar mode, Shift+Tab does not go directly to the toolbar but the first tabstop outside of the editor.

Co-authored-by: Alex Lende <ajlende@gmail.com>
Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

No branches or pull requests

1 participant