Try: use ariakit for DropdownMenu v2, test it in block editor settings
#54612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.03 kB (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 967bb13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6313340010
|
ciampo
force-pushed
the
try/droprown-v2-ariakit-test
branch
6 times, most recently
from
7298894
to
b5f168b
Compare
|
Good news! After the latest Here's a quick video highlighting a nested dropdown menu across slotfills. Clicking on the nested items correctly opens our first-party modal. Focus is handled correctly too. Kapture.2023-09-26.at.12.15.36.mp4 |
|
I'll start pulling out some updates from this PR and land them individually, starting from updating |
|
@diegohaz it would be great to have your eyes on the code in this PR, to make sure that the overall approach is correct (especially around using a custom react context to pass the store around the components, so that we can leverage it also in slot fills) |
ciampo
force-pushed
the
try/droprown-v2-ariakit-test
branch
from
a2a1939
to
967bb13
Compare
Where does focus return to when the modal is closed? It looks like the submenu collapses when you click on "Create pattern", so I'm guessing not there! Not a big thing right now, but something to think about as we progress. |
|
Good point! The video is outdated though, the problem should have been solved by this commit |
|
Closing this PR as it only served as a quick way to check ariakit's compatibility with some aspects of the editor. Please follow #50459 for updates related to the next version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aims at investigating if
ariakit'sMenucan handle all edge cases that were flagged while working on theradix-uiversion (see #51400)Why?
We want to provide a new version of
DropdownMenu, supporting (among other things) nested submenus.How?
Things to look for:
Modalcomponent, command palette, any browser extensions like GTranslate)<a />) as menu itemsTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast