Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor sidebar: unable to scroll, Save button hidden #48796

Closed
jameskoster opened this issue Mar 6, 2023 · 4 comments
Closed

Site Editor sidebar: unable to scroll, Save button hidden #48796

jameskoster opened this issue Mar 6, 2023 · 4 comments
Assignees
@youknowriad
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jameskoster
Copy link
Contributor

When there are a long list of items in the sidebar the save button gets pushed off the viewport entirely, and it's not possible to scroll the contents to view it:

scroll.mp4

cc @youknowriad
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 6, 2023
@carolinan
Copy link
Contributor

I can reproduce this if Gutenberg trunk is active, but not with only 6.2-beta4-55469. (chrome, macos)

@t-hamano
Copy link
Contributor

t-hamano commented Mar 7, 2023

I expect this is due to the removal of the overflow:hidden; in #48399.
https://github.com/WordPress/gutenberg/pull/48399/files#diff-b948436daf4637baf6bada5f65931d841feed7039369fba4176b1afb23d497f4L56

This PR has been backported to WordPress 6.2 and I believe this issue needs to be fixed. However, simply reverting to this CSS seems a bit unnatural. The reason is that the description panel added by #48739 scrolls at the same time.

4ae1275598d468a3d40c4b1edd5a8308.mp4

@youknowriad
Copy link
Contributor

I've got a fix coming

@youknowriad youknowriad mentioned this issue Mar 7, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 7, 2023
@ntsekouras
Copy link
Contributor

Fixed here: #48822

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
WordPress 6.2 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix site editor sidebar scrollbars WordPress/gutenberg
6 participants
@youknowriad @jameskoster @carolinan @ntsekouras @priethor @t-hamano