-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Scrollbar in site editor. #48822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected ✅
No, the problem with this PR is that the "footer" (save area) remains hidden when the sidebar is long. |
Size Change: +20 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one works too 👍
I'm confused why the snapshots appear to need updating. I'll try running them, but if anyone else knows what's up, feel free to dive in. |
Let's go with this solution since it also fixes scrollbar styles. |
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: cd1a50e |
* Fix: Scrollbar in site editor. * Fix issue with save panel.
What?
Alternative to #48819. Fixes the site editor to be scrollable again, with the light-weight scrollbars:
Why?
Bug/regression.
How?
The scrollable container needs to be the 100% tall container.
Testing Instructions
Go into the site editor > templates, and make your viewport not so tall and hover the sidebar to see a scrollbar.