Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add deep link to Global Styles panel styles=open #49585

Open
luminuu opened this issue Apr 4, 2023 · 5 comments
Open

Re-add deep link to Global Styles panel styles=open #49585

luminuu opened this issue Apr 4, 2023 · 5 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@luminuu
Copy link
Member

luminuu commented Apr 4, 2023

Description

The deep link for opening the Global Styles panel directly worked until 6.1, but got removed in 6.2 again when Browse Mode was introduced.

On January 20, 2022 this was done in this PR, after being accidentally removed: #38093

With PR #44770 this part of the code was removed: https://github.com/WordPress/gutenberg/pull/44770/files#diff-53f39da7a5f1f996f5359a2dd7b2747fb3d60a494523dd73dba946fab8e82592

Related to this is this discussion about the link from the WP Dashboard: #38172

With reintroducing styles=open as parameter, it would be possible again to deep link to the Site Editor with the Global Styles panel open, in combination with canvas=edit to skip the Browse Mode interface.

Step-by-step reproduction instructions

  1. Open the site editor on a WP 6.1 with site-editor.php?styles=open: the site editor opens, as well as the Global Styles panel on the right side.
  2. Do the same on a 6.2 install: the site editor opens, but the right sidebar stays at the Template view.

Screenshots, screen recording, code snippet

No response

Environment info

  • WP 6.2, latest Gutenberg (active and deactivated), Twenty Twenty-Three

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Apr 4, 2023
@annezazu annezazu added the Needs Design Feedback Needs general design feedback. label Apr 10, 2023
@annezazu
Copy link
Contributor

Noting that we'll likely want some design feedback here as a high level Styles tab is being added to the dark grey sidebar of the site editor (aka "browse mode" project name): #49014 This is evolving so there might be a future, clearer pathway to initiate the Styles interface while using the new site editing experience. For now though, @ntsekouras curious if this is something you could work on after your recent work to deep link with Styles for different functionality #49350

@jasmussen
Copy link
Contributor

While I think we still have some work to do separately, to improve the clarity of the uniqueness of the global style inspector in the fullscreen view (compared to the block inspector), technically I would consider this issue fixed in the next version of the plugin, where the Styles section, including a deep-link as suggested, has landed recently.

Shown here, a GIF navigating into the Site editor > Styles > Edit styles:

style link

@luminuu
Copy link
Member Author

luminuu commented Apr 11, 2023

While I think we still have some work to do separately, to improve the clarity of the uniqueness of the global style inspector in the fullscreen view (compared to the block inspector), technically I would consider this issue fixed in the next version of the plugin, where the Styles section, including a deep-link as suggested, has landed recently.

Will this deep link also be available to be called from outside of the editor, e. g. another admin page?

@jasmussen
Copy link
Contributor

Will this deep link also be available to be called from outside of the editor, e. g. another admin page?

That is not my instinct at this time, no, I think one of the benefits of a "Site View" in the editor being that it can gather all block-design related tools together in one place. At the same time, if this becomes a pain point for someone constantly wanting to revisit this from the top level, we'll definitely want to revisit that, perhaps people can "pin" items to the top level if they want to.

@clubkert
Copy link
Contributor

I'll just add that a lot of our users have a hard time finding Global Styles today (and I know this is being worked on separately, which is great).

Being able to say something like "click here to edit your site style" or "click here to pick another style variation" would be helpful. Instead of needing to say "click here and then navigate to xyz to pick another style variation."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants