Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Site Design controls in Go Site Editing. #2524

Closed
wants to merge 5 commits into from

Conversation

AnthonyLedesma
Copy link
Member

Description

The Site Design controls were built with classic theme functionality in mind. The Site Editor controls now replicate the behavior of the Site Design controls inside of CoBlocks and we no longer need this tool with GSE.

With this PR the controls will remain as backward compatible.

Screenshots

Screen Shot 2023-04-07 at 5 38 45 PM

Types of changes

PHP and JS mods to allow conditional disable for GSE context.

How has this been tested?

Tested manually. Needs tests still.

Acceptance criteria

Should disable when Go is updated to GSE.
Should have a test in place to simulate conditions.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added [Status] Do Not Merge Issues/PRs that should not be merged (yet) [Type] Needs Tests This issue/pull request requires proper tests implemented labels Apr 8, 2023
@AnthonyLedesma AnthonyLedesma self-assigned this Apr 8, 2023
@AnthonyLedesma
Copy link
Member Author

Maybe we should explore hiding the controls altogether. Right now things are still disabled. Having controls disabled here has the benefit of showing, even if a user is on another theme, it still points them to get GSE where they have baked-in site design controls.

@AnthonyLedesma
Copy link
Member Author

AnthonyLedesma commented Apr 8, 2023

Even better if we can deep-link into the GSE design controls. @jrtashjian Do you think it is reasonable to deep-link straight to the Site Editor in Go? See the image for details - we can have a link.
Core may have a solution for us soon.

WordPress/gutenberg#49585

@EvanHerman EvanHerman modified the milestone: 3.0.3 Apr 20, 2023
@eherman-godaddy
Copy link
Contributor

PR is no longer relevant as we are not uplifting Go to FSE and the site design controls will still work.

@olafleur-godaddy olafleur-godaddy deleted the go/site-design-mods branch April 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Do Not Merge Issues/PRs that should not be merged (yet) [Type] Needs Tests This issue/pull request requires proper tests implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants