-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Site Design controls in Go Site Editing. #2524
Conversation
Maybe we should explore hiding the controls altogether. Right now things are still disabled. Having controls disabled here has the benefit of showing, even if a user is on another theme, it still points them to get GSE where they have baked-in site design controls. |
|
PR is no longer relevant as we are not uplifting Go to FSE and the site design controls will still work. |
Description
The Site Design controls were built with classic theme functionality in mind. The Site Editor controls now replicate the behavior of the Site Design controls inside of CoBlocks and we no longer need this tool with GSE.
With this PR the controls will remain as backward compatible.
Screenshots
Types of changes
PHP and JS mods to allow conditional disable for GSE context.
How has this been tested?
Tested manually. Needs tests still.
Acceptance criteria
Should disable when Go is updated to GSE.
Should have a test in place to simulate conditions.
Checklist: