Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template vs content editing UX: notification hard to see against dark background #51300

Open
annezazu opened this issue Jun 7, 2023 · 6 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 7, 2023

While doing some early testing of #49980, I noticed that the notification around editing a template is hard to see when using a darker background. This obviously applies for any notification in the Site Editor but feels important to consider if we're relying on it to indicate a path for a user to take for editing purposes.

hard.to.see.black.background.mov
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 7, 2023
@noisysocks
Copy link
Member

Technically this is an issue with all notifications. Should we add a border or shadow to our toast notifications? cc. @SaxonF

@annezazu
Copy link
Contributor Author

Talking with @joedolson about this today at WCEU -- he brought up a great point around how the notifications have no proximity to the action you're taking. Worth considering from a design perspective and with these sorts of section based editing.

@noisysocks noisysocks added the [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. label Jun 26, 2023
@noisysocks
Copy link
Member

@SaxonF @jameskoster: How should we address this?

@SaxonF
Copy link
Contributor

SaxonF commented Jun 26, 2023

I think we should address this more globally as a notification issue with content vs template editing as an example. I'm not really sure how we'd get around the colour issue. Switching to white background (matching modals, dropdowns) might help as shadow helps with contrast against white background. We could also tinker with animation or position (e.g. bottom centred) to make it more visible on appear and look at introducing icons in different scenarios.

@annezazu could we reframe this as a notification/toast improvement focusing on increasing visibility?

@noisysocks noisysocks added General Interface Parts of the UI which don't fall neatly under other labels. and removed [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. labels Jun 26, 2023
@annezazu
Copy link
Contributor Author

That totally works!

@beckej13820
Copy link

I just want to leave a +1 comment about what @annezazu and @joedolson said.

Please remember that for first time users of Site Editor experience, the first template they may try to edit is the header template.

I was completely unaware of the notification in the lower left hand corner of the screen, because I was trying to edit near the top of my screen. I think the location of the alert is the most important thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants