Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template vs content editing UX: improve block settings content to better indicate possible actions #51302

Closed
annezazu opened this issue Jun 7, 2023 · 1 comment · Fixed by #51881
Assignees
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 7, 2023

While doing some early testing of #49980, I noticed that it shows as “no block selected” in the sidebar when you're on the block tab:

no.block.selected.mov

It also doesn't provide any visual clarity in the sidebar when on the Page tab:

page.tab.mov

This feels like a missed opportunity, especially when the notice is hard to see on a dark background #51300 and only seems to appear once.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 7, 2023
@noisysocks noisysocks added the [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. label Jun 26, 2023
@noisysocks
Copy link
Member

While doing some early testing of #49980, I noticed that it shows as “no block selected” in the sidebar when you're on the block tab:

I think the solution here is to mimic what happens in the other editors where we switch to the Page tab when you unselect a block. I'll work on a fix for that.

This feels like a missed opportunity, especially when the notice is hard to see on a dark background #51300 and only seems to appear once.

This notice will appear again now as of #51366.

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended and removed Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. labels Jun 26, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 26, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants