Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "copy link" action to link preview #53655

Closed
richtabor opened this issue Aug 14, 2023 · 2 comments · Fixed by #58170
Closed

Add "copy link" action to link preview #53655

richtabor opened this issue Aug 14, 2023 · 2 comments · Fixed by #58170
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Aug 14, 2023

This proposal adds a control to copy the selected link, which is a common editing action. This feature also brings a bit of editing parity with Google docs.

This reduces the current flow where to copy a link, you need to:

  • Click the edit icon, then click into the link field and finally copy the contents of that field.
  • Click the title within the link preview (opening a new tab), click into the browser URL/search bar, then copy its contents.

Visual

copy-link

Note this visual is based on the changes proposed in #53654.

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Aug 14, 2023
@richtabor
Copy link
Member Author

Let's put copy at the end of the three icons: edit, unlink, copy.

@richtabor
Copy link
Member Author

Should "Copy" have the full link in a tooltip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant