Add copy link button to Link UI #58170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +46 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Jan 24, 2024
|
@MaggieCabrera How did this experience test for Voiceover? |
The button is announced exactly like the other two, and it prompts to use command+option+space to copy the URL and that worked too. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #53655
Why?
It's a good quality of life improvement.
How?
Adds a copy button to the preview state of Link UI and uses the copy to clipboard hook to do the action. It also shows a confirmation notice.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
copy-link.mp4