Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: Preview area requires default white background #54533

Closed
t-hamano opened this issue Sep 18, 2023 · 0 comments · Fixed by #54534
Closed

Patterns: Preview area requires default white background #54533

t-hamano opened this issue Sep 18, 2023 · 0 comments · Fixed by #54534
Assignees
@t-hamano
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

If the background color is not defined in theme.json, such as Emptytheme, the background color of the preview area will not be applied. This isn't an issue with a white-based canvas, but on the Site Editor's Patterns page, for example, the black background can make it difficult to see the content in the preview.

actual

What is your proposed solution?

I think a default white background is required.

expected
@t-hamano t-hamano added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Sep 18, 2023
@t-hamano t-hamano mentioned this issue Sep 18, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 18, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patterns: Apply white background to the preview as a fallback WordPress/gutenberg
2 participants
@jordesign @t-hamano