Patterns: Apply white background to the preview as a fallback #54534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
[Feature] Patterns
|
Size Change: +41 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 78cf864. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6218346811
|
|
@aaronrobertshaw Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54533
What?
This PR applies a white background to the pattern page preview when the currently activated theme does not have a background color.
Why?
This is because if the currently active theme does not have a background color, it will be affected by the black canvas background behind the preview.
How?
If the background color obtained via the
useGlobalStylehook isundefined, the default white color is passed to the BlockPreview component.Before this approach, I also tried a simple CSS solution as follows.
However, this is not a problem for themes that do not define a background color, but for themes that do have a background color, the following flickering occurs:
Screencast
864f979559cbeda0e27e2f83aa177805.mp4
Testing Instructions
headertemplate is white.