-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support two align variations: "full-width" and "wide". #546
Comments
Would the button in toolbar appear just for images? We are training people UI wise to expect actions in the toolbar, so we should as a result not change that with this UI. |
With very few exceptions (I think List might not have any alignments in the first version) we'd have only two types of alignments: text alignments (for text specific blocks) and block level block level alignments, which you see here.
Can you elaborate? |
It depends where the placing is. We seem to have a training of:
If we follow that then it makes sense. I may just need to see this in prototype as assuming from the images. |
Here's a blueprint for the various terms we've dubbed. The toolbar docked to the block is the Quick Toolbar, and the button that would control alignment would be the Block Level Formatting group. In the blueprint it shows block level formatting for text, i.e. text alignments. But for any other block, image included, this would instead show layout alignments, like float left, center, right, wide, full width. |
@mtias having thought about this for a long time now, I think the best we can do here is add the extra icon: It's the least mystery meat of all the solutions I've explored, and it keeps the behavior or the buttons to simply be toggles, not steppers. What do you think? I can add the dashicon real quick, then perhaps we can get in the full-bleed branch soon also? |
Sounds good. |
New icon upstream in Dashicons: WordPress/dashicons#191 |
This PR updates Dashicons, and adds a new full-width icon. This renames the old icon to "wide". See also discussion in #546
This is fixed in master now! 🎉 |
Instead of single setting for full bleed images, it can be a "stepped" control—wide, wider, fullwidth. It needs some design work for the UI. It can work really well with galleries and hero-image.
The text was updated successfully, but these errors were encountered: