Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Block: Retry does not work for URLs with a trailing slash #58002

Closed
t-hamano opened this issue Jan 19, 2024 · 0 comments · Fixed by #58007
Closed

Embed Block: Retry does not work for URLs with a trailing slash #58002

t-hamano opened this issue Jan 19, 2024 · 0 comments · Fixed by #58007
Assignees
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@t-hamano
Copy link
Contributor

Description

This is the regression discovered in this comment: #57969 (comment)

If the Embed block fails to embed a URL with a trailing slash, as shown in this test, it should remove the slash and try to embed it again. This has been implemented in #14705, but for some reason it doesn't work now so we had to skip testing it.

Step-by-step reproduction instructions

  • Insert an Embed Block or a Twitter Block.
  • Enter the Twitter URL with a trailing slash: https://twitter.com/WordPress/
    • Expected: The URL should be converted to https://twitter.com/WordPress without the trailing slash, and Twitter should be embedded successfully.
    • Actual: The embedding should fail and the URL should remain the same.

Screenshots, screen recording, code snippet

675532d2fe002004c7dffc7e50182629.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Block] Embed Affects the Embed Block labels Jan 19, 2024
@t-hamano t-hamano self-assigned this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant