Migrate 'embedding' e2e tests to Playwright #57969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
commented
Jan 18, 2024
Comment on lines
+191
to
+192
| // Reason: A possible regression of https://github.com/WordPress/gutenberg/pull/14705. | ||
| test.skip( 'should retry embeds that could not be embedded with trailing slashes, without the trailing slashes', async ( { |
There was a problem hiding this comment.
This test is currently failing. When I try to test this scenario manually, it doesn't work at all. I'm skipping the test for now, and we can enable it when regression is fixed.
There was a problem hiding this comment.
I also confirmed that retry doesn't work. Should we open a new issue as a regression?
There was a problem hiding this comment.
Yes, let's open the new issue and reference this PR.
Mamaduka
requested review from
WunderBart and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Jan 19, 2024
| await expect( | ||
| currenEmbedBlock.locator( 'figure' ), | ||
| 'Video content. Should render valid figure element, and include the aspect ratio class.' | ||
| ).toHaveClass( /wp-embed-aspect-16-9/ ); |
There was a problem hiding this comment.
If we strictly migrate the original tests, do we also need to check the .wp-block-embed and .is-type-video classes?
There was a problem hiding this comment.
I've altered the assertion based on the error message.
There was a problem hiding this comment.
I see, that's certainly true 👍
| await embedUtils.insertEmbed( 'https://twitter.com/notnownikki' ); | ||
| await expect( | ||
| currenEmbedBlock.locator( 'iframe' ), | ||
| 'Valid embed. Should render valid element.' |
There was a problem hiding this comment.
I didn't know that we could specify an optional message as the second argument 😄
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
embedding.test.jse2e tests to Playwright.Why?
See #38851.
Testing Instructions