-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Inherit query from template' setting is confusing #63598
Comments
Can we find a way to inform users when the default query does not work? Like in the post content, or in a custom page template. |
Thank you for adding this issue James! Thinking out loud / brainstorming. Looking at the phrase used today: The following words can be difficult to understand: global query context ........ in current template Ideas.... The main issue is to make it easier to understand what is going on here with as few as possible words. The more words the more difficult it can be to not understand what is going on. Explaining what happens with toggle on or off can be helpful so the user understands what both do. |
Love those suggestions, @paaljoachim. I'd only include filters in the help text because they also modify the query and it's rather common for people to display a filterable list/grid of posts or other items. If we stick to a toggle, we should only use one copy variant to avoid confusing people ("is the feature enabled or not?"). In that case, Jay's early suggestion can work better, allowing us to describe each outcome clearly. What if we put the button in a dedicated |
Good input, thanks y'all.
Maybe we could even simplify even further: "Use the default query e.g. category archive or search results". Additionally, since the help text uses the word I appreciate filtering archives is a common pattern in WooCommerce, but it's not really possible (except for search) in core, so I'd probably omit that part for the sake of simplicity. Start with less. The Content panel is an interesting idea and does resonate. But it would be antithetical with other Content panels, which exist to help users locate editable blocks in the current context. That one might be worth visiting separately.
This is an excellent point. I can't think of a single use case for a Query inside a Content block to inherit (can you?). Maybe the option should be automatically set to custom, and the control hidden from the UI when Query Loop is placed inside Content? |
I feel like we're closing in on something here, and could potentially think about opening a PR, but would welcome wider feedback :) |
Copy wise, can we reduce the technical terminology further? Terms like "global query settings" and 'primary query in a template" don't connect well for most folks. Maybe something along the lines of: Use the current template's blog settings to display posts. Customize which posts are displayed. |
It's tricky because "blog settings" doesn't really apply to templates like archive.html or search.html which can show more than just blog posts. Maybe we omit that part? "Use the template settings to display entries". Or "Use site settings to display entries". |
"posts" rather than "entries"? |
Could "items" work? We'd then use the copy in other situations, like displaying products, tags, etc. |
Hey, I made a draft PR with the discussed change: #63739. The copy can be easily tweaked if necessary but we have a base. 🙌 |
Yeah I think it needs to be more generic as there are so many cases where templates can display different post types. Maybe:
|
But they're all posts right? "Content" may be fine, but it feels like a case where being too generic makes it confusing for more people. |
Not always, the query can be used for other post types. We may call them post types, but for a user a page is not a post. |
Yes, but if you're configuring a Query Loop block, I am confident "post" is more relative than "item" or "content", even if it's not a "post". I'm just a bit hesitant to use new words for existing concepts. Combining the feedback from above, what do you think of this? Query Type Custom Post Type |
Sounds good to me! Then QL derivatives like Product Collection could slightly tweak the copy while remaining aligned with the core block. The only thing I'm not sure of is the button's label. I also wonder if the description should say Content Custom Post Type |
Brain storming... If we aim for the general user then keeping it as simple as possible would be helpful.
The above gives more of a every day language feel to it.
Default text. Feels right away more advanced. Mentioning custom post types can confuse quite a few users. What about just saying Display posts based on the current template. |
I appreciate that "Content" could be ambiguous, which is a trade-off. But I also agree that "Custom post types" is starting to sound technical again. The average user will have no idea what that means. In the spirit of ideas being cheap, here's a different angle:
Yes, "query" is technical, but we're already within the context of the "Query Loop" block, so it's not a new concept. Side note: I wonder if it's helpful to include a recommendation, IE:
|
This makes me wonder if we shouldn't rename the block at some point. Both Query and Loop are words that most non-technical users are unlikely to be familiar with. Something like @paaljoachim's suggestion reads well to me. But again, I wonder if we need a help text for
|
Yea, but only introduced after pages and posts. I think it's important to not make it unclear what the block can do, especially to developers. |
I'd totally support a drastic simplification of the (too long) help text for the settings. As mentioned in #58207 the help text could be way shorter. More detailed descriptions and instructions can be provided by using a link pointing to some external documentation. The editor already does that in a few cases. |
Gave it a try and here's how it looks based on @richtabor 's suggestion: queryloopinspectorcontrols.mov |
I'm not following. Adding posts to a page, without all the fields for "Custom", doesn't seem like a stretch to me. If it's set to "Default", I get the default posts query, with the standard posts per page count. |
I totally agree it's a legitimate use case, but that's not how the block works. A Query Loop inside a page inherits from the queried object which is the page itself. There's currently a bug; the canvas doesn't match the frontend: query.mp4What you're describing feels more like a case for a variation that queries a specific post type and all of it's associated taxonomies, e.g. "Posts list", "Products list", etc. Related: #40941 |
The 'inherit query from template' setting asks users to comprehend complex details within the context of an already-complex block.
There are likely longer-term fundamental changes to make that would eliminate the need for this setting, but that doesn't mean we can't attempt to make the control more intuitive in the short term.
The text was updated successfully, but these errors were encountered: