-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content/Wide controls need 40px-compatible design #64842
Comments
A few more points from the duplicate issue #64862
|
I wouldn't say they are ornamental or confusing. The label "Content" on its own is not enough to convey what it's referring to. I think the combination of icon/label here helps a lot with clarity. In particular, seeing one icon next to the other gives you the information as to which of the two inputs should hold the higher value. |
Labeling and descriptions could be improved as well. I do agree the label 'Content' is not ideal. As a used, I'm confused by teh description as ell: Same applies to the label 'Wide'.
Makes me think I can set ONE width. Instead, they may conditionally be two. I disagree about the icons. As a used, those icons don't tell anything useful to me. They look clickable because they editor uses this pattern for clickable buttons. They aren't clickable though and that breaks an established design pattern. |
When editing blocks, these widths are named differently and are clearer. Basically:
Worth also reminding that themes may support only one of the widths. In that case, the editor UI will show only one control, where the icon is even more unnecessary and confusing. Screenshot: I'd totally agree with this comment from @jameskoster :
As such, I think the best option for now is to just remove these icons. |
I agree the labelling is inconsistent and confusing. It might be worth extracting that into it's own issue if you have a moment @afercia. Somewhat related; the "Inner blocks use content width" toggle is confusing. It assumes some conceptual understanding of "Content width", which is likely to be lacking in most cases. There is some value in the icon though, imo. It visually connects these settings to the associated toolbar options. @mirka I don't particularly love either option, but here are a couple of ideas how we might solve the original issue. The help text refers to these inputs as a single control, perhaps they could be visually presented as such. Would this create the necessary space? Style overrides are a shame. Alternatively we could split the inputs onto separate rows, but also display the labels inline so they do not consume so much vertical space: This would be a departure from existing layout conventions, but perhaps there are other controls that would benefit from this orientation...? |
I also agree the icons are valuable. To mitigate the issue of it seeming clickable, I'm hoping we can codify this in our design guidelines for input-like controls that the prefix slot should be used for informational cues and never interactive things. As for the layout suggestions in #64842 (comment), I'm concerned about how these decisions will scale. Unless we can present clear guidelines on when exactly these new patterns should be deployed, it's just going to lead to entropy. So I'm wondering if we can solve this within the bounds of our already existing patterns. To be honest I'm not seeing how breaking the two controls into two rows (with the standard label placement) is going to make them seem unrelated. If anything, the icon ties them together. If we're really concerned about them being perceived as a group, maybe they should be in their own Panel section? Or is the primary concern here to maintain a small footprint? |
I think the help text should be conditional. Actually depending on theme support for As mentioned in #64906 (comment) the concept of 'Content width' has been used for ages in WordPress but that's because of the Overall, I struggle with this UI because it doesn't explain well what these two inputs are about. I'd love to see the descriptions and label explain it clearly. Something along these lines, in prose: When both are supported by the theme:
When only one of them is supported:
For the similar inputs in the Group block settings panel a similar wording should be used, making clear that they are meant to override the global values. |
What problem does this address?
The Content/Wide inputs used in Layout and Dimensions controls have a design that cannot be converted to the new 40px control sizes in a straightforward way.
Even with tweaks to decrease the footprint of all the relevant elements (#64708, #64712), we still have some overflow even in one of the more optimistic cases ("px" unit in Chrome, which supports CSS
field-sizing
), if there is a visible scrollbar in the sidebar:What is your proposed solution?
Some of the suggested solutions were:
All which were not ideal for one reason or another. This is one of the last remaining controls with the older 36px size, so we need a new design as soon as possible.
The text was updated successfully, but these errors were encountered: