Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashicons: Prefix icon name to avoid bleed #719

Closed
jasmussen opened this issue May 9, 2017 · 0 comments · Fixed by #768
Closed

Dashicons: Prefix icon name to avoid bleed #719

jasmussen opened this issue May 9, 2017 · 0 comments · Fixed by #768
Assignees
@jasmussen
Labels
[Type] Enhancement A suggestion for improvement.
Milestone
May Week 3 (Alpha)

Comments

@jasmussen
Copy link
Contributor

jasmussen commented May 9, 2017 •
edited
Loading

Right now SVGs in the dashicons sprite have these CSS classes:

<svg class="dashicon button" xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 20 20"><title>Button</title><path d="M17 5H3c-1.1 0-2 .9-2 2v6c0 1.1.9 2 2 2h14c1.1 0 2-.9 2-2V7c0-1.1-.9-2-2-2zm1 7c0 .6-.4 1-1 1H3c-.6 0-1-.4-1-1V7c0-.6.4-1 1-1h14c.6 0 1 .4 1 1v5z"></path></svg>

This causes CSS bleed for the button class:

screen shot 2017-05-09 at 10 12 36

We should fix the build process upstream so the class is instead dashicons-button, to avoid this bleed, and update references.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label May 9, 2017
@jasmussen jasmussen self-assigned this May 9, 2017
@jasmussen jasmussen added this to the Alpha milestone May 10, 2017
jasmussen added a commit that referenced this issue May 11, 2017
@jasmussen
Fix dashicons CSS bleed
aa32ffb 
This PR fixes #719, but adding a `dashicons-` prefix to the CSS classes applied to the SVGs.

It also changes the Button block to use the new button icon.

Upstream PR: WordPress/dashicons#183
@jasmussen jasmussen mentioned this issue May 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
May Week 3 (Alpha)
Development

Successfully merging a pull request may close this issue.

Fix dashicons CSS bleed WordPress/gutenberg
1 participant
@jasmussen