Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Consider resetting test site when running end-to-end tests #8010

Closed
aduth opened this issue Jul 17, 2018 · 1 comment
Closed

Testing: Consider resetting test site when running end-to-end tests #8010

aduth opened this issue Jul 17, 2018 · 1 comment
Assignees
@tofumatt
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.

Comments

@aduth
Copy link
Member

aduth commented Jul 17, 2018

If a previous end-to-end test run is abruptly terminated, it can leave the test site in a fragmented state where test plugins will be pre-activated on the next test run, causing unexpected test failures which are difficult to debug.

We should consider automatically disabling any activated plugins when the end-to-end test suite starts. In most cases, this will not need to do anything, but will account for the rare case where it does.
@aduth aduth added [Type] Enhancement A suggestion for improvement. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Jul 17, 2018
@tofumatt
Copy link
Member

I agree, it'd be good not to have to re-run tests to clear themselves out.

This ties into #7959, and I think can be easily accomplished by resetting the (soon-to-be-sepaarte, hopefully, test) site with WP CLI using npm's pretest script.

@tofumatt tofumatt self-assigned this Jul 18, 2018
tofumatt added a commit that referenced this issue Jul 19, 2018
@tofumatt
chore: Isolate e2e tests and reset themn for each run
040c201 
Fixes #7959
Fixes #8010
@tofumatt tofumatt mentioned this issue Jul 19, 2018
Merged
tofumatt added a commit that referenced this issue Jul 21, 2018
@tofumatt
chore: Isolate e2e tests and reset themn for each run
946ad7c 
Fixes #7959
Fixes #8010
tofumatt added a commit that referenced this issue Jul 26, 2018
@tofumatt
chore: Isolate e2e tests and reset them for each run (#8041)
1a0b22a 
* chore: Isolate e2e tests and reset themn for each run

Fixes #7959
Fixes #8010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tofumatt @aduth