Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The BaseControl (TextControl etc.) label is too wide #9612

Closed
afercia opened this issue Sep 4, 2018 · 1 comment · Fixed by #14478
Closed

The BaseControl (TextControl etc.) label is too wide #9612

afercia opened this issue Sep 4, 2018 · 1 comment · Fixed by #14478
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Sep 4, 2018

By default, the BaseControl <label> element is styled as a block element with display: block;. The controls that extends from it, for example TextControl, inherit the "block" label.

While this may not be a big issue for controls that are rendered in the narrow space (e.g. the sidebar):

textcontrol label 1

it may be a bit annoying when the space is wider, for example in the content area, where the chance to trigger unwanted clicks is higher:

textcontrol label 2

As a small enhancement, maybe worth considering some different styling.

@afercia afercia added the [Type] Enhancement A suggestion for improvement. label Sep 4, 2018
@mtias mtias added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. labels Oct 8, 2018
@karmatosed
Copy link
Member

Assuming it adapts well I think a good iteration so design approving this.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Oct 8, 2018
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants