Use inline-block to limit label width to content

[sbardian]

Description

Closes #9612. Use display: inline-block instead of display: block to limit BaseControl label to width of the content of the label.

How has this been tested?

• npm run test all tests successful.
• manually looked at different blocks with labels. Obviously not an exhaustive test, and will be willing to look at anything else to confirm this change.

Screenshots

before:

after:

before:

after:

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.

[jorgefilipecosta]

Hi @sbardian thank you for your contribution.
I did a set of tests and I only found a small regression.
If you add a video block, you will verify the poster image button does not appear as expected.

I guess a possible solution is to add a display block to the poster image.

[sbardian]

I have updated the poster control button to use display: block. This should only change the poster control button, but makes we wonder if others might need this as well. . . thoughts?

[sbardian]

@jorgefilipecosta let me know if you would like other updates, or can see/think of other issues this might cause?

[jorgefilipecosta]

Hi @sbardian, thank you for these changes it looks good to me.
I guess this change worths a note in the changelog https://github.com/WordPress/gutenberg//blob/6a26e3682ff79be3a031d283b6466a236f9748db/packages/components/CHANGELOG.md as an improvement under the last unreleased version.

[sbardian]

@jorgefilipecosta I have the notes added. Thanks!

[draganescu]

Hi @sbardian I tried to visually test this but whenever I checkout the branch the build fails. Could you rebase it with latest master in your fork?

[sbardian]

Sorry for all the reviews on this. Only thing I can think of is history was rewritten in master at some point? Shouldn't have conflicts now.

[noisysocks]

Thanks for the fix, @sbardian!