Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a simpler spacing setup for gallery items #10027

Merged
merged 8 commits into from
Sep 25, 2018

Commits on Sep 19, 2018

  1. Try a simpler spacing setup for gallery items

    The stock gallery features white gutters between items. Currently in `master`, every item has an even 8px margin all around. We then compensate for this, left and right, of the gallery, to make sure items in the gallery align correctly with text width above and below the gallery.
    
    This PR attempts a different approach. It sets only the right and bottom margin on gallery items, and then unsets the right margin on the rightmost item in each row.
    
    This is a little more complex in the rules that are output, but it solves the issue presented here: #9670 (comment)
    
    Let me know your thoughts.
    Joen Asmussen committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    ae7796e View commit details
    Browse the repository at this point in the history
  2. Clean up the mess.

    Remove debug comments. Sorry, long day.
    
    Clarify comments.
    Joen Asmussen committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    90d0808 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2018

  1. Address feedback.

    Joen Asmussen committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    e87089c View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Address feedback.

    Joen Asmussen committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    42d3e93 View commit details
    Browse the repository at this point in the history
  2. Bugfix.

    Joen Asmussen committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    8ea5725 View commit details
    Browse the repository at this point in the history
  3. Adjust gallery css layout math, and ensure margin is reset correctly …

    …at mobile breakpoints
    
    Co-authored-by: Sofia Sousa <csofiamsousa@gmail.com>
    talldan and SofiaSousa committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    a620ead View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. Fix odd rule

    Joen Asmussen committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    1c24a11 View commit details
    Browse the repository at this point in the history
  2. Add fixed rule

    Joen Asmussen committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    ec58508 View commit details
    Browse the repository at this point in the history