-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try a simpler spacing setup for gallery items #10027
Merged
Merged
Commits on Sep 19, 2018
-
Try a simpler spacing setup for gallery items
The stock gallery features white gutters between items. Currently in `master`, every item has an even 8px margin all around. We then compensate for this, left and right, of the gallery, to make sure items in the gallery align correctly with text width above and below the gallery. This PR attempts a different approach. It sets only the right and bottom margin on gallery items, and then unsets the right margin on the rightmost item in each row. This is a little more complex in the rules that are output, but it solves the issue presented here: #9670 (comment) Let me know your thoughts.
Joen Asmussen committedSep 19, 2018 Configuration menu - View commit details
-
Copy full SHA for ae7796e - Browse repository at this point
Copy the full SHA ae7796eView commit details -
Remove debug comments. Sorry, long day. Clarify comments.
Joen Asmussen committedSep 19, 2018 Configuration menu - View commit details
-
Copy full SHA for 90d0808 - Browse repository at this point
Copy the full SHA 90d0808View commit details
Commits on Sep 20, 2018
-
Joen Asmussen committed
Sep 20, 2018 Configuration menu - View commit details
-
Copy full SHA for e87089c - Browse repository at this point
Copy the full SHA e87089cView commit details
Commits on Sep 21, 2018
-
Joen Asmussen committed
Sep 21, 2018 Configuration menu - View commit details
-
Copy full SHA for 42d3e93 - Browse repository at this point
Copy the full SHA 42d3e93View commit details -
Joen Asmussen committed
Sep 21, 2018 Configuration menu - View commit details
-
Copy full SHA for 8ea5725 - Browse repository at this point
Copy the full SHA 8ea5725View commit details -
Adjust gallery css layout math, and ensure margin is reset correctly …
…at mobile breakpoints Co-authored-by: Sofia Sousa <csofiamsousa@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a620ead - Browse repository at this point
Copy the full SHA a620eadView commit details
Commits on Sep 25, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1c24a11 - Browse repository at this point
Copy the full SHA 1c24a11View commit details -
Joen Asmussen committed
Sep 25, 2018 Configuration menu - View commit details
-
Copy full SHA for ec58508 - Browse repository at this point
Copy the full SHA ec58508View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.