Install phpcs using Composer
#1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
approved these changes
Jun 5, 2017
|
✅ |
ntwb
requested changes
Jun 6, 2017
.editorconfig
Outdated
| @@ -8,7 +8,7 @@ charset = utf-8 | |||
| trim_trailing_whitespace = true | |||
| insert_final_newline = true | |||
|
|
|||
| [{package.json,.travis.yml}] | |||
| [{package.json,.travis.yml,composer.json}] | |||
There was a problem hiding this comment.
How about [{*.json,.travis.yml}] so it also covers .eslintrc.json and any other .json files?
There was a problem hiding this comment.
Done. This aligns better with core: https://github.com/WordPress/wordpress-develop/blob/4.7.5/.editorconfig#L16-L18
The package.json should be updated to use 2-space indents.
|
Thanks for the fixes & improvements here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #986 (comment), another way to install
phpcsandWordPress-Coding-Standardsis viacomposer. This PR explores this option.Still left to do:
phpcs --config-setcall, if possible