Fix gallery margin while typing #10221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#10027 introduced a small bug where the last item in a gallery jumps around when a user is in the process of adding a caption. This is due to a `:nth-last-child(2)` style rule that is applied to a gallery when it has an `is-selected` class, but not an `is-typing` class. This PR modifies that rule to include the `is-typing` class and remove the jump.
kjellr
added
[Type] Bug
jasmussen
approved these changes
Sep 28, 2018
|
Great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10027 introduced a small bug where the last item in a gallery sometimes jumps around when a user is in the process of adding a caption.
This is due to a
:nth-last-child(2)style rule that is applied to a gallery when it has anis-selectedclass, but not anis-typingclass.This PR modifies that rule to include the
is-typingclass and remove the jump.Before:
After
